src/compiler/ia32/instruction-selector-ia32.cc - Issue 877753007: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ia32/instruction-selector-ia32.cc

Issue 877753007: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: VS201x now happy? Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/ia32/instruction-selector-ia32.cc

diff --git a/src/compiler/ia32/instruction-selector-ia32.cc b/src/compiler/ia32/instruction-selector-ia32.cc

index 233fa3767044ba83cac3fe52ceafe3c99e222916..b81210a7050be051887206f2730dca5f647ffb7d 100644

--- a/src/compiler/ia32/instruction-selector-ia32.cc

+++ b/src/compiler/ia32/instruction-selector-ia32.cc

@@ -370,8 +370,8 @@ static void VisitBinop(InstructionSelector* selector, Node* node,

outputs[output_count++] = g.DefineAsRegister(cont->result());

}

- DCHECK_NE(0, input_count);

- DCHECK_NE(0, output_count);

+ DCHECK_NE(0u, input_count);

+ DCHECK_NE(0u, output_count);

DCHECK_GE(arraysize(inputs), input_count);

DCHECK_GE(arraysize(outputs), output_count);

« no previous file with comments | « src/compiler/ia32/code-generator-ia32.cc ('k') | src/compiler/instruction.h » ('j') | no next file with comments »