src/arm/code-stubs-arm.cc - Issue 877753007: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/code-stubs-arm.cc

Issue 877753007: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: VS201x now happy? Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/code-stubs-arm.cc

diff --git a/src/arm/code-stubs-arm.cc b/src/arm/code-stubs-arm.cc

index 2e585ba53ab94f692a237556918eb67d4ee1b243..a8c374fd1d11595a05148c25ac4233f8477f7ff6 100644

--- a/src/arm/code-stubs-arm.cc

+++ b/src/arm/code-stubs-arm.cc

@@ -561,7 +561,7 @@ void CompareICStub::GenerateGeneric(MacroAssembler* masm) {

// If either is a Smi (we know that not both are), then they can only

// be strictly equal if the other is a HeapNumber.

STATIC_ASSERT(kSmiTag == 0);

- DCHECK_EQ(0, Smi::FromInt(0));

+ DCHECK_EQ(static_cast<Smi*>(0), Smi::FromInt(0));

__ and_(r2, lhs, Operand(rhs));

__ JumpIfNotSmi(r2, &not_smis);

// One operand is a smi. EmitSmiNonsmiComparison generates code that can:

« no previous file with comments | « src/api.cc ('k') | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »