Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

src/compiler/register-allocator-verifier.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/bit-vector.h"
 #include "src/compiler/instruction.h"
 #include "src/compiler/register-allocator-verifier.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 static size_t OperandCount(const Instruction* instr) {
   return instr->InputCount() + instr->OutputCount() + instr->TempCount();
 }
 
 
 static void VerifyGapEmpty(const GapInstruction* gap) {
   for (int i = GapInstruction::FIRST_INNER_POSITION;
        i <= GapInstruction::LAST_INNER_POSITION; i++) {
     GapInstruction::InnerPosition inner_pos =
         static_cast<GapInstruction::InnerPosition>(i);
-    CHECK_EQ(NULL, gap->GetParallelMove(inner_pos));
+    CHECK(!gap->GetParallelMove(inner_pos));
   }
 }
 
 
 void RegisterAllocatorVerifier::VerifyInput(
     const OperandConstraint& constraint) {
   CHECK_NE(kSameAsFirst, constraint.type_);
   if (constraint.type_ != kImmediate) {
     CHECK_NE(UnallocatedOperand::kInvalidVirtualRegister,
              constraint.virtual_register_);
@@ skipping 391 matching lines @@
       }
       // Found correct definition or use.
       if (v->define_vreg != kInvalidVreg) {
         CHECK(v->define_vreg == phi->first_pred_vreg);
       } else if (v->use_vreg != phi->first_pred_vreg) {
         // Walk the phi chain, hunting for a matching phi use.
         auto p = phi;
         for (; p != nullptr; p = p->first_pred_phi) {
           if (p->virtual_register == v->use_vreg) break;
         }
-        CHECK_NE(nullptr, p);
+        CHECK(p);
       }
       // Mark the use.
       it->second->use_vreg = use_vreg;
       return;
     }
     // Use of a phi value without definition.
-    CHECK(false);
+    UNREACHABLE();
   }
 
  private:
   Map map_;
   DISALLOW_COPY_AND_ASSIGN(OperandMap);
 };
 
 }  // namespace
 
 
@@ skipping 217 matching lines @@
         int virtual_register = op_constraints[count].virtual_register_;
         current->Define(zone(), instr->OutputAt(i), virtual_register);
       }
     }
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8