Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: pkg/analysis_server/test/services/index/store/codec_test.dart

Issue 877693004: Fix for file:// package: references to the same element. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/index/store/codec_test.dart
diff --git a/pkg/analysis_server/test/services/index/store/codec_test.dart b/pkg/analysis_server/test/services/index/store/codec_test.dart
index 1a79bccf3576b6337414b4abdca75bae4e9b70cc..f2c7c5fefcf3c5501e0bd26b3a9a34d6c93cee94 100644
--- a/pkg/analysis_server/test/services/index/store/codec_test.dart
+++ b/pkg/analysis_server/test/services/index/store/codec_test.dart
@@ -8,6 +8,7 @@ import 'package:analysis_server/src/services/index/index.dart';
import 'package:analysis_server/src/services/index/store/codec.dart';
import 'package:analyzer/src/generated/element.dart';
import 'package:analyzer/src/generated/engine.dart';
+import 'package:analyzer/src/generated/source.dart';
import 'package:unittest/unittest.dart';
import '../../../abstract_single_unit.dart';
@@ -121,6 +122,36 @@ class A {
}
}
+ void test_filePackage_uriMix() {
+ MethodElement buildMethodElement(Source source) {
+ CompilationUnitElementImpl unitElement = new CompilationUnitElementImpl('file.dart');
+ LibraryElementImpl libraryElement = new LibraryElementImpl(null, 'lib', 0);
+ ClassElementImpl classElement = new ClassElementImpl('A', 0);
+ MethodElementImpl methodElement = new MethodElementImpl('m', 0);
+ unitElement.source = source;
+ libraryElement.definingCompilationUnit = unitElement;
+ unitElement.types = [classElement];
+ classElement.methods = [methodElement];
+ return methodElement;
+ }
+ // file:
+ int fileId;
+ {
+ Source source = new _TestSource('/my/file.dart', 'file:///my/file.dart');
+ var methodElement = buildMethodElement(source);
+ fileId = codec.encode(methodElement, true);
+ }
+ // package:
+ int packageId;
+ {
+ Source source = new _TestSource('/my/file.dart', 'package:my_pkg/file.dart');
+ var methodElement = buildMethodElement(source);
+ packageId = codec.encode(methodElement, true);
+ }
+ // should be the same
+ expect(packageId, fileId);
+ }
+
void test_localLocalVariable() {
resolveTestUnit('''
main() {
@@ -229,3 +260,13 @@ class _StringCodecTest {
expect(codec.decode(idB), 'bbb');
}
}
+
+
+class _TestSource implements Source {
+ String fullName;
+ String encoding;
+
+ _TestSource(this.fullName, this.encoding);
+
+ noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation);
+}

Powered by Google App Engine
This is Rietveld 408576698