Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 877643002: Reland of "Steps towards unification of number bitset and range types." (Closed)

Created:
5 years, 11 months ago by Jarin
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "Steps towards unification of number bitset and range types." This reverts commit 76193749791eac9032f47db2f04efd78c0e120a9. BUG= Committed: https://crrev.com/5bd8407f8c8d7ed08574ca532ae5f1f4d6a8b39f Cr-Commit-Position: refs/heads/master@{#26301}

Patch Set 1 : Original commit. #

Patch Set 2 : Fix rebase. #

Patch Set 3 : Avoid (some of the) uninhabited type normalization based on representation. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+494 lines, -254 lines) Patch
M src/compiler/change-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/typer.cc View 2 chunks +44 lines, -33 lines 0 comments Download
M src/types.h View 1 11 chunks +80 lines, -62 lines 0 comments Download
M src/types.cc View 1 2 18 chunks +297 lines, -97 lines 1 comment Download
M src/types-inl.h View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 2 chunks +14 lines, -18 lines 0 comments Download
M test/cctest/test-types.cc View 7 chunks +35 lines, -36 lines 0 comments Download
M test/cctest/types-fuzz.h View 2 chunks +5 lines, -0 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Jarin
Could you take a look, please? I am introducing a hack to get to the ...
5 years, 11 months ago (2015-01-27 07:16:37 UTC) #2
Benedikt Meurer
So I guess that means that you just work-around the representation problem? https://codereview.chromium.org/877643002/diff/40001/src/types.cc File src/types.cc ...
5 years, 10 months ago (2015-01-27 18:13:47 UTC) #3
rossberg
OK, why did the previous isolate hack not work? Are the changes with respect to ...
5 years, 10 months ago (2015-01-27 19:13:20 UTC) #4
Jarin
On 2015/01/27 19:13:20, rossberg wrote: > OK, why did the previous isolate hack not work? ...
5 years, 10 months ago (2015-01-28 08:39:37 UTC) #5
Benedikt Meurer
lgtm
5 years, 10 months ago (2015-01-28 08:40:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877643002/40001
5 years, 10 months ago (2015-01-28 08:40:59 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-28 08:42:23 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 08:42:44 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5bd8407f8c8d7ed08574ca532ae5f1f4d6a8b39f
Cr-Commit-Position: refs/heads/master@{#26301}

Powered by Google App Engine
This is Rietveld 408576698