content/browser/service_worker/service_worker_url_request_job_unittest.cc - Issue 877623002: [ServiceWorker] Fills SSLInfo of the response from a SW with the SSLInfo of the SW script.

Unified Diff: content/browser/service_worker/service_worker_url_request_job_unittest.cc

Issue 877623002: [ServiceWorker] Fills SSLInfo of the response from a SW with the SSLInfo of the SW script. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DCHECK(!http_response_info_); Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_url_request_job.cc ('K') | « content/browser/service_worker/service_worker_url_request_job.cc ('k') | content/browser/service_worker/service_worker_version.h » ('j') | content/browser/service_worker/service_worker_version.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_url_request_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_url_request_job_unittest.cc b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

index 28986dea607564b6864f13bfc6349eff63b75249..772bdf28a2d1cd81423552d689a6ca99aa7ade07 100644

--- a/content/browser/service_worker/service_worker_url_request_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_url_request_job_unittest.cc

@@ -31,8 +31,11 @@

#include "content/public/test/test_browser_context.h"

#include "content/public/test/test_browser_thread_bundle.h"

#include "net/base/io_buffer.h"

+#include "net/base/test_data_directory.h"

#include "net/http/http_request_headers.h"

#include "net/http/http_response_headers.h"

+#include "net/ssl/ssl_info.h"

+#include "net/test/cert_test_util.h"

#include "net/url_request/url_request.h"

#include "net/url_request/url_request_context.h"

#include "net/url_request/url_request_job_factory_impl.h"

@@ -125,6 +128,12 @@ class ServiceWorkerURLRequestJobTest : public testing::Test {

GURL("http://example.com/service_worker.js"),

1L,

helper_->context()->AsWeakPtr());

+ net::SSLInfo ssl_info;

+ ssl_info.cert =

+ net::ImportCertFromFile(net::GetTestCertsDirectory(),

+ "ok_cert.pem");

+ EXPECT_TRUE(ssl_info.is_valid());

Ryan Sleevi 2015/01/28 01:04:02 Hrm. This is probably bad for //net that we expose

horo 2015/01/28 02:32:05 Done.

+ version_->SetMainScriptSSLInfo(ssl_info);

scoped_ptr<ServiceWorkerProviderHost> provider_host(

new ServiceWorkerProviderHost(

@@ -180,6 +189,7 @@ class ServiceWorkerURLRequestJobTest : public testing::Test {

EXPECT_EQ(expected_status_text,

request_->response_headers()->GetStatusText());

EXPECT_EQ(expected_response, url_request_delegate_.response_data());

+ EXPECT_TRUE(request_->response_info().ssl_info.is_valid());

}

bool HasInflightRequests() {