Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 877613003: V8EventListenerList should use its own hidden name, otherwise the hidden name conflicts (Closed)

Created:
5 years, 11 months ago by haraken
Modified:
5 years, 11 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

V8EventListenerList should use its own hidden name, otherwise the hidden name conflicts Currently V8EventListenerList uses "listener" but this conflicts with AudioContext::listener and thus causes mysterios crash. This CL renames "listener" to "EventListenerList::listener". BUG=449610 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189006

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
A LayoutTests/webaudio/audiocontext-listener-should-not-crash.html View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/webaudio/audiocontext-listener-should-not-crash-expected.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/V8EventListenerList.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
haraken
PTAL
5 years, 11 months ago (2015-01-26 07:53:02 UTC) #2
Jens Widell
LGTM
5 years, 11 months ago (2015-01-26 07:55:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877613003/20001
5 years, 11 months ago (2015-01-26 07:57:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/47728)
5 years, 11 months ago (2015-01-26 09:54:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877613003/20001
5 years, 11 months ago (2015-01-26 11:25:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877613003/40001
5 years, 11 months ago (2015-01-27 01:41:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/43785)
5 years, 11 months ago (2015-01-27 03:14:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877613003/60001
5 years, 11 months ago (2015-01-27 04:29:43 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 05:43:03 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189006

Powered by Google App Engine
This is Rietveld 408576698