Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 877613002: Added pairing with Spake SHA224 key exchange. (Closed)

Created:
5 years, 11 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@brillo1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added pairing with Spake SHA224 key exchange. Pairing generates secret know to the session and device. The secret will be used for for certificate validation and for device authentication. BUG=449864 Committed: https://crrev.com/09933be8d731339201df0a9df91bfdaffedd7771 Cr-Commit-Position: refs/heads/master@{#313890}

Patch Set 1 #

Patch Set 2 : Sun 01/25/2015 23:30:32.39 #

Patch Set 3 : Sun 01/25/2015 23:51:07.99 #

Total comments: 7

Patch Set 4 : Mon Jan 26 16:15:06 PST 2015 #

Patch Set 5 : Tue Jan 27 15:07:05 PST 2015 #

Patch Set 6 : Tue Jan 27 15:17:09 PST 2015 #

Patch Set 7 : Tue Jan 27 15:18:39 PST 2015 #

Patch Set 8 : Tue Jan 27 15:19:41 PST 2015 #

Patch Set 9 : Thu Jan 29 10:05:26 PST 2015 #

Patch Set 10 : Thu Jan 29 10:44:08 PST 2015 #

Patch Set 11 : Thu Jan 29 10:46:32 PST 2015 #

Patch Set 12 : Thu Jan 29 15:56:05 PST 2015 #

Patch Set 13 : Thu Jan 29 22:04:41 PST 2015 #

Patch Set 14 : Thu Jan 29 23:44:10 PST 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+541 lines, -163 lines) Patch
M chrome/browser/extensions/api/gcd_private/gcd_private_api.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +7 lines, -14 lines 0 comments Download
M chrome/browser/local_discovery/privetv3_session.h View 1 2 3 4 6 7 2 chunks +52 lines, -4 lines 0 comments Download
M chrome/browser/local_discovery/privetv3_session.cc View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +254 lines, -38 lines 0 comments Download
M chrome/browser/local_discovery/privetv3_session_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +187 lines, -45 lines 0 comments Download
M chrome/test/data/extensions/api_test/gcd_private/api/session.js View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +10 lines, -19 lines 0 comments Download
M chrome/test/data/extensions/api_test/gcd_private/api/wifi_message.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +25 lines, -34 lines 0 comments Download

Messages

Total messages: 34 (13 generated)
Vitaly Buka (NO REVIEWS)
5 years, 11 months ago (2015-01-26 08:00:10 UTC) #2
Vitaly Buka (NO REVIEWS)
5 years, 11 months ago (2015-01-26 08:03:00 UTC) #3
Aleksey Shlyapnikov
lgtm https://codereview.chromium.org/877613002/diff/40001/chrome/browser/local_discovery/privetv3_session.cc File chrome/browser/local_discovery/privetv3_session.cc (right): https://codereview.chromium.org/877613002/diff/40001/chrome/browser/local_discovery/privetv3_session.cc#newcode48 chrome/browser/local_discovery/privetv3_session.cc:48: char kPrivetV3PairingConfirmPath[] = "/privet/v3/pairing/confirm"; Make them all const ...
5 years, 10 months ago (2015-01-26 21:47:46 UTC) #4
Vitaly Buka (NO REVIEWS)
5 years, 10 months ago (2015-01-26 23:14:34 UTC) #6
Vitaly Buka (NO REVIEWS)
On 2015/01/26 23:14:34, Vitaly Buka wrote: Zen, Max this change will break compatibility with py ...
5 years, 10 months ago (2015-01-26 23:17:51 UTC) #7
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/877613002/diff/40001/chrome/browser/local_discovery/privetv3_session.cc File chrome/browser/local_discovery/privetv3_session.cc (right): https://codereview.chromium.org/877613002/diff/40001/chrome/browser/local_discovery/privetv3_session.cc#newcode48 chrome/browser/local_discovery/privetv3_session.cc:48: char kPrivetV3PairingConfirmPath[] = "/privet/v3/pairing/confirm"; On 2015/01/26 21:47:45, Aleksey Shlyapnikov ...
5 years, 10 months ago (2015-01-27 00:16:33 UTC) #8
mednik
On 2015/01/26 23:17:51, Vitaly Buka wrote: > On 2015/01/26 23:14:34, Vitaly Buka wrote: > > ...
5 years, 10 months ago (2015-01-27 04:34:06 UTC) #9
Vitaly Buka (NO REVIEWS)
On 2015/01/27 04:34:06, mednik wrote: > On 2015/01/26 23:17:51, Vitaly Buka wrote: > > On ...
5 years, 10 months ago (2015-01-27 17:33:57 UTC) #10
Aleksey Shlyapnikov
lgtm
5 years, 10 months ago (2015-01-27 23:20:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877613002/160001
5 years, 10 months ago (2015-01-29 18:09:13 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/116874)
5 years, 10 months ago (2015-01-29 18:40:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877613002/180001
5 years, 10 months ago (2015-01-29 18:45:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877613002/200001
5 years, 10 months ago (2015-01-29 18:47:17 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/21048)
5 years, 10 months ago (2015-01-29 19:21:22 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877613002/220001
5 years, 10 months ago (2015-01-29 23:59:14 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/19758)
5 years, 10 months ago (2015-01-30 00:57:02 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877613002/240001
5 years, 10 months ago (2015-01-30 06:05:46 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/28800)
5 years, 10 months ago (2015-01-30 07:24:30 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877613002/260001
5 years, 10 months ago (2015-01-30 07:46:30 UTC) #32
commit-bot: I haz the power
Committed patchset #14 (id:260001)
5 years, 10 months ago (2015-01-30 09:37:48 UTC) #33
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 09:39:13 UTC) #34
Message was sent while issue was closed.
Patchset 14 (id:??) landed as
https://crrev.com/09933be8d731339201df0a9df91bfdaffedd7771
Cr-Commit-Position: refs/heads/master@{#313890}

Powered by Google App Engine
This is Rietveld 408576698