Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2592)

Unified Diff: android_webview/tools/copyright_scanner.py

Issue 877583003: [Android WebView] Fix outstanding license check issues on the release bot (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/tools/copyright_scanner_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/tools/copyright_scanner.py
diff --git a/android_webview/tools/copyright_scanner.py b/android_webview/tools/copyright_scanner.py
index be21231ec2ff41a5937ecdb42c0a45e72f853461..fb403fdeaaf24fc67131f7ef8d233f4d484efa99 100644
--- a/android_webview/tools/copyright_scanner.py
+++ b/android_webview/tools/copyright_scanner.py
@@ -75,7 +75,9 @@ def FindFiles(input_api, root_dir, start_paths_list, excluded_dirs_list):
# Data is not part of open source chromium, but are included on some bots.
path_join('data'),
# This is not part of open source chromium, but are included on some bots.
- path_join('skia', 'tools', 'clusterfuzz-data')
+ path_join('skia', 'tools', 'clusterfuzz-data'),
+ # Not shipped, only relates to Chrome for Android, but not to WebView
+ path_join('clank'),
]
excluded_dirs_list.extend(EXTRA_EXCLUDED_DIRS)
@@ -311,7 +313,8 @@ def AnalyzeScanResults(input_api, whitelisted_files, offending_files):
"Stale" are files that are whitelisted unnecessarily.
"""
unknown = set(offending_files) - set(whitelisted_files)
- missing = [f for f in whitelisted_files if not input_api.os_path.isfile(f)]
+ missing = [f for f in whitelisted_files if not input_api.os_path.isfile(
+ input_api.os_path.join(input_api.change.RepositoryRoot(), f))]
stale = set(whitelisted_files) - set(offending_files) - set(missing)
return (list(unknown), missing, list(stale))
« no previous file with comments | « no previous file | android_webview/tools/copyright_scanner_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698