Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 877583003: [Android WebView] Fix outstanding license check issues on the release bot (Closed)

Created:
5 years, 10 months ago by mnaganov (inactive)
Modified:
5 years, 10 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Fix outstanding license check issues on the release bot - fix missing files check for the case when the script runs outside of the repository root; - exclude not shipped dirs that present on the bot from the checks. BUG=450048 Committed: https://crrev.com/da58b9ae8fabdd2047cdea05bc749e8697edeed2 Cr-Commit-Position: refs/heads/master@{#314310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M android_webview/tools/copyright_scanner.py View 2 chunks +5 lines, -2 lines 0 comments Download
M android_webview/tools/copyright_scanner_unittest.py View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/tools/webview_licenses.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mnaganov (inactive)
5 years, 10 months ago (2015-02-02 18:39:45 UTC) #2
Torne
lgtm
5 years, 10 months ago (2015-02-03 10:29:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877583003/1
5 years, 10 months ago (2015-02-03 10:35:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 11:09:27 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 11:10:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da58b9ae8fabdd2047cdea05bc749e8697edeed2
Cr-Commit-Position: refs/heads/master@{#314310}

Powered by Google App Engine
This is Rietveld 408576698