Unit test for non-default orientation images which don't produce pixels.

Unit test for non-default orientation images which don't produce pixels.

This is a unit test based on the fuzzer-reported bug, which fails in an
MSAN build. This set of conditions is somewhat odd, but it's required to
trigger the code path in question.

BUG=450389
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189816

[jbroman, 2015-02-07 18:12:42]

jbroman@chromium.org changed reviewers:
+ schenney@chromium.org

[jbroman, 2015-02-07 18:12:43]

This unit test reproduces the MSAN issue I recently fixed.

[Stephen Chennney, 2015-02-09 14:51:00]

LGTM.

I'm a bit surprised that there are no subclasses of BitmapImage that require the
constructors you moved to private. It compiles though, so I'm assuming it's OK.
Could you verify?

[jbroman, 2015-02-09 14:55:22]

On 2015/02/09 14:51:00, Stephen Chenney wrote:
> LGTM.
> 
> I'm a bit surprised that there are no subclasses of BitmapImage that require
the
> constructors you moved to private. It compiles though, so I'm assuming it's
OK.
> Could you verify?

I cannot find any subclasses of BitmapImage at all.

[jbroman, 2015-02-09 14:55:58]

On 2015/02/09 14:55:22, jbroman wrote:
> On 2015/02/09 14:51:00, Stephen Chenney wrote:
> > LGTM.
> > 
> > I'm a bit surprised that there are no subclasses of BitmapImage that require
> the
> > constructors you moved to private. It compiles though, so I'm assuming it's
> OK.
> > Could you verify?
> 
> I cannot find any subclasses of BitmapImage at all.

Given that, perhaps I should just make the entire "protected" section private .
. .

[Stephen Chennney, 2015-02-09 15:04:09]

On 2015/02/09 14:55:58, jbroman wrote:
> On 2015/02/09 14:55:22, jbroman wrote:
> > On 2015/02/09 14:51:00, Stephen Chenney wrote:
> > > LGTM.
> > > 
> > > I'm a bit surprised that there are no subclasses of BitmapImage that
require
> > the
> > > constructors you moved to private. It compiles though, so I'm assuming
it's
> > OK.
> > > Could you verify?
> > 
> > I cannot find any subclasses of BitmapImage at all.
> 
> Given that, perhaps I should just make the entire "protected" section private
.
> . .

Sure. I'd be on board with that.

[jbroman, 2015-02-09 15:07:37]

New patchsets have been uploaded after l-g-t-m from schenney@chromium.org

[jbroman, 2015-02-09 15:49:19]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2015-02-09 15:50:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/877553011/60001

[commit-bot: I haz the power, 2015-02-09 17:13:28]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189816