Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 877553010: Fix Mac gyp error with disable_nacl (Closed)

Created:
5 years, 10 months ago by tapted
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Mac gyp error with disable_nacl r314575 removed a default `files` array on the `Internet Plug-Ins` Mac bundle subfolder, so it was only added with disable_nacl=0 This adds an empty default array to match the targets below. Committed: https://crrev.com/072ef39848b879faa486c76568c1b023524f0fb3 Cr-Commit-Position: refs/heads/master@{#314738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/chrome_dll_bundle.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
5 years, 10 months ago (2015-02-05 02:44:47 UTC) #2
Nico
lgtm
5 years, 10 months ago (2015-02-05 02:50:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877553010/1
5 years, 10 months ago (2015-02-05 02:52:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 03:43:27 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 03:44:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/072ef39848b879faa486c76568c1b023524f0fb3
Cr-Commit-Position: refs/heads/master@{#314738}

Powered by Google App Engine
This is Rietveld 408576698