Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: third_party/harfbuzz-ng/BUILD.gn

Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: yet more feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/thunk/BUILD.gn ('k') | third_party/libxml/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/harfbuzz-ng/BUILD.gn
diff --git a/third_party/harfbuzz-ng/BUILD.gn b/third_party/harfbuzz-ng/BUILD.gn
index 71213fd42945432143bb50f7b79cda3747f49b23..90b200f3897a6209cbc4060a25cf7b60e432de07 100644
--- a/third_party/harfbuzz-ng/BUILD.gn
+++ b/third_party/harfbuzz-ng/BUILD.gn
@@ -13,27 +13,20 @@ import("//build/config/linux/pkg_config.gni")
# don't want to bloat the binary more by including another copy.
declare_args() {
- if (is_linux && (!is_official_build || is_chromeos)) {
- # Since version 1.31.0, pangoft2 which we depend on pulls in harfbuzz
- # anyways. However, we want to have control of the version of harfbuzz
- # we use, so don't use system harfbuzz for official builds, unless we
- # are building for chrome os, where we have the system harfbuzz under
- # control as well.
- use_system_harfbuzz = exec_script(pkg_config_script,
- pkg_config_args + [
- "--atleast-version=1.31.0",
- "pangoft2",
- ],
- "value")
- } else {
- use_system_harfbuzz = false
- }
- if (is_linux && current_cpu == "arm" && !is_chromeos) {
- # Override use_system_harfbuzz for ARM cross compiling so system
- # harfbuzz is not used because the corresponding package is not
- # available.
- use_system_harfbuzz = false
- }
+ # Since version 1.31.0, pangoft2 which we depend on pulls in harfbuzz
+ # anyways. However, we want to have control of the version of harfbuzz
+ # we use, so don't use system harfbuzz for official builds, unless we
+ # are building for chrome os, where we have the system harfbuzz under
+ # control as well. We also do not want to use the system harfbuzz
+ # when cross-compiling for ARM.
+ use_system_harfbuzz = is_linux && (is_chromeos || (!is_official_build &&
+ current_cpu != "arm")) &&
+ exec_script(pkg_config_script,
+ pkg_config_args + [
+ "--atleast-version=1.31.0",
+ "pangoft2",
+ ],
+ "value")
}
if (use_system_harfbuzz) {
« no previous file with comments | « ppapi/thunk/BUILD.gn ('k') | third_party/libxml/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698