ppapi/shared_impl/BUILD.gn - Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/shared_impl/BUILD.gn

Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: yet more feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/shared_impl/BUILD.gn

diff --git a/ppapi/shared_impl/BUILD.gn b/ppapi/shared_impl/BUILD.gn

index 14c65bc2b34d72a900a94007a741748b20a56d45..59f4ec05ee333afbdc8a0d0c6e28fda7b0c5d791 100644

--- a/ppapi/shared_impl/BUILD.gn

+++ b/ppapi/shared_impl/BUILD.gn

@@ -172,13 +172,18 @@ component("shared_impl") {

"//media:shared_memory_support",

"//ppapi/c",

"//ppapi/thunk",

- "//skia",

"//third_party/icu:icuuc",

- "//ui/events:events_base",

- "//ui/surface",

"//url",

]

+ if (!is_nacl) {

+ deps += [

+ "//skia",

+ "//ui/events:events_base",

+ "//ui/surface",

+ ]

+ }

if (is_mac) {

libs = [ "QuartzCore.framework" ]

}

« no previous file with comments | « ppapi/proxy/BUILD.gn ('k') | ppapi/thunk/BUILD.gn » ('j') | no next file with comments »