Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: mojo/nacl/BUILD.gn

Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: yet more feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/BUILD.gn ('k') | ppapi/native_client/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/nacl/BUILD.gn
diff --git a/mojo/nacl/BUILD.gn b/mojo/nacl/BUILD.gn
index 222d45f6b94cf8f58e0df2881bf6f48015d482e8..6a6373c81e7b158ee8020fc143614066464ac53f 100644
--- a/mojo/nacl/BUILD.gn
+++ b/mojo/nacl/BUILD.gn
@@ -35,6 +35,7 @@ if (!is_nacl) {
"$gen_dir/mojo_syscall.cc",
"monacl_sel_main.cc",
]
+
deps = [
# This target makes sure we have all the pre-processor defines needed to
# use NaCl's headers.
@@ -43,20 +44,8 @@ if (!is_nacl) {
"//native_client/src/trusted/service_runtime:sel_main_chrome",
":mojo_nacl_codegen($default_toolchain)",
]
- }
-
- # A simple shell for running untrusted binaries that talk to the Mojo
- # embedder. (No services.)
- executable("monacl_shell") {
- testonly = true
- sources = [
- "monacl_shell.cc",
- ]
- deps = [
- "//base:base",
- "//third_party/mojo/src/mojo/edk/system:system",
- ":monacl_sel",
- ]
+ public_configs =
+ [ "//third_party/mojo/src/mojo/public/build/config:mojo_sdk" ]
}
}
@@ -68,37 +57,22 @@ if (is_nacl) {
"$gen_dir/libmojo.cc",
"$gen_dir/mojo_irt.h",
]
- include_dirs = [ "$root_build_dir/gen" ]
- deps = [
- ":mojo_nacl_codegen($default_toolchain)",
- ]
- }
- # Unit test for the Mojo public API.
- executable("monacl_test") {
- testonly = true
- sources = [
- "//third_party/mojo/src/mojo/public/cpp/system/tests/core_unittest.cc",
- "//third_party/mojo/src/mojo/public/cpp/system/tests/macros_unittest.cc",
- ]
- deps = [
- "//testing/gtest:gtest",
- "//testing/gtest:gtest_main",
- "//third_party/mojo/src/mojo/public/c/system/tests:tests",
- "//third_party/mojo/src/mojo/public/cpp/system:system",
- ":mojo",
+ public_configs =
+ [ "//third_party/mojo/src/mojo/public/build/config:mojo_sdk" ]
+
+ public_deps = [
+ ":mojo_nacl_codegen($default_toolchain)",
]
}
- executable("irt_mojo") {
+ source_set("irt_mojo_sources") {
cflags_c = [ "-std=c99" ]
sources = [
- "irt_entry_mojo.c",
"$gen_dir/mojo_irt.c",
"$gen_dir/mojo_irt.h",
]
- include_dirs = [ "$root_build_dir/gen" ]
- deps = [
+ public_deps = [
"//native_client/build/config/nacl:nacl_base",
"//native_client/src/untrusted/irt:irt_core_lib",
"//native_client/src/untrusted/nacl:imc_syscalls",
@@ -106,17 +80,3 @@ if (is_nacl) {
]
}
}
-
-group("mojo_nacl") {
- deps = [
- ":irt_mojo(//native_client/build/toolchain/nacl:irt_${current_cpu})",
- ]
-}
-
-group("mojo_nacl_tests") {
- testonly = true
- deps = [
- ":monacl_shell",
- ":monacl_test(//native_client/build/toolchain/nacl:clang_newlib_${current_cpu})",
- ]
-}
« no previous file with comments | « ipc/BUILD.gn ('k') | ppapi/native_client/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698