chrome/app/BUILD.gn - Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/BUILD.gn

Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: yet more feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/BUILD.gn

diff --git a/chrome/app/BUILD.gn b/chrome/app/BUILD.gn

index 12e3b12f6e474e6f5e315e188b793dd361c5ae1d..b7dfb20eece9a1cd46cffd0e691c7769362f9b4e 100644

--- a/chrome/app/BUILD.gn

+++ b/chrome/app/BUILD.gn

@@ -318,9 +318,9 @@ source_set("test_support") {

sources += [ "chrome_main_mac.mm" ]

}

- # TODO(gyp) if (enable_plugins and enable_nacl) {

- # deps += [ "'<(DEPTH)/components/nacl/renderer/plugin/plugin.gyp:nacl_trusted_plugin'," ]

- # }

+ if (enable_plugins && enable_nacl) {

+ deps += [ "//components/nacl/renderer/plugin:nacl_trusted_plugin" ]

+ }

if (enable_remoting) {

deps += [ "//remoting/client/plugin" ]

« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »