chrome/BUILD.gn - Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: yet more feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index a807c09e5eea9c002c92c99d62a7944003e11293..5b40f4f186bbc11ed02c3a2e5063d0501da0a99d 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -279,9 +279,9 @@ group("child_dependencies") {

deps += [ "//third_party/cld_2:cld2_platform_impl" ]

}

- # TODO(gyp) if (enable_nacl) {

- # deps += [ "<(DEPTH)/components/nacl/renderer/plugin/plugin.gyp:nacl_trusted_plugin" ]

- #}

+ if (enable_nacl) {

+ deps += [ "//components/nacl/renderer/plugin:nacl_trusted_plugin" ]

+ }

if (enable_remoting) {

deps += [ "//remoting/client/plugin" ]

}

« no previous file with comments | « build/config/features.gni ('k') | chrome/app/BUILD.gn » ('j') | no next file with comments »