Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: mojo/nacl/BUILD.gn

Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clean up for review Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/nacl/BUILD.gn
diff --git a/mojo/nacl/BUILD.gn b/mojo/nacl/BUILD.gn
index 3ce017d44c0cca6eb33e44cdfa62bff98430ec9f..e15035a0b34d94291e5cd63c3614532e9efc6533 100644
--- a/mojo/nacl/BUILD.gn
+++ b/mojo/nacl/BUILD.gn
@@ -33,6 +33,9 @@ if (!is_nacl) {
"$gen_dir/mojo_syscall.cc",
"monacl_sel_main.cc",
]
+
+ include_dirs = [ "//third_party/mojo/src" ]
brettw 2015/02/05 00:20:36 It seems that this should reference a config rathe
Dirk Pranke 2015/02/05 00:26:16 Yeah, I thought about doing that but at the time w
Nick Bray (chromium) 2015/02/05 23:21:46 This file should really be coming from the Mojo re
Dirk Pranke 2015/02/05 23:52:19 Right, that's what brett is suggesting.
Dirk Pranke 2015/02/06 02:57:27 Brett, Nick, are you two okay with me leaving this
brettw 2015/02/06 06:06:15 I'm just concerned that if it gets moved it will b
+
deps = [
# This target makes sure we have all the pre-processor defines needed to
# use NaCl's headers.
@@ -68,6 +71,7 @@ if (is_nacl) {
deps = [
":mojo_nacl_codegen($default_toolchain)",
]
+ include_dirs = [ "//third_party/mojo/src" ]
}
# Unit test for the Mojo public API.
@@ -77,6 +81,7 @@ if (is_nacl) {
"//third_party/mojo/src/mojo/public/cpp/system/tests/core_unittest.cc",
"//third_party/mojo/src/mojo/public/cpp/system/tests/macros_unittest.cc",
]
+ include_dirs = [ "//third_party/mojo/src" ]
deps = [
"//native_client/src/untrusted/nacl:imc_syscalls",
"//testing/gtest:gtest",

Powered by Google App Engine
This is Rietveld 408576698