BUILD.gn - Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge to #317924 Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index f0ba26da16689036c3a07d5da62689f21caa198a..86e320c7f5b00ec66854da59f916096b80a941a9 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -164,6 +164,13 @@ group("gn_all") {

]

}

+ if (enable_nacl && enable_nacl_untrusted) {

+ if (is_linux && current_cpu == "x64") {

+ # TODO(GYP): Add the right deps for the other architectures.

+ # TODO(dpranke) needed? deps += [ "//ppapi:ppapi_cpp_lib(//native_client/build/toolchain/nacl:clang_newlib_x64)" ]

Dirk Pranke 2015/02/25 21:08:46 It looks like we don't need to explicitly build th

brettw 2015/02/25 21:27:29 Yes, remove this.

+ }

if (is_win || is_mac || is_chromeos) {

# RLZ works on these platforms.

# TODO(GYP): Is this target needed, or pulled in automatically?

« no previous file with comments | « no previous file | base/BUILD.gn » ('j') | base/BUILD.gn » ('J')