Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: third_party/harfbuzz-ng/BUILD.gn

Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: yet more feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ppapi/thunk/BUILD.gn ('k') | third_party/libxml/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/linux/pkg_config.gni") 5 import("//build/config/linux/pkg_config.gni")
6 6
7 # The GYP build supports system harfbuzz for non-official builds when using 7 # The GYP build supports system harfbuzz for non-official builds when using
8 # pangoft2 1.31.0 or greater (which pulls it in). 8 # pangoft2 1.31.0 or greater (which pulls it in).
9 # TODO(brettw) we can consider doing this as well, although the benefit is 9 # TODO(brettw) we can consider doing this as well, although the benefit is
10 # unclear and requires shelling out to a script to check the version. 10 # unclear and requires shelling out to a script to check the version.
11 # 11 #
12 # ChromeOS uses an up-to-date system one that we have control over, so we 12 # ChromeOS uses an up-to-date system one that we have control over, so we
13 # don't want to bloat the binary more by including another copy. 13 # don't want to bloat the binary more by including another copy.
14 14
15 declare_args() { 15 declare_args() {
16 if (is_linux && (!is_official_build || is_chromeos)) { 16 # Since version 1.31.0, pangoft2 which we depend on pulls in harfbuzz
17 # Since version 1.31.0, pangoft2 which we depend on pulls in harfbuzz 17 # anyways. However, we want to have control of the version of harfbuzz
18 # anyways. However, we want to have control of the version of harfbuzz 18 # we use, so don't use system harfbuzz for official builds, unless we
19 # we use, so don't use system harfbuzz for official builds, unless we 19 # are building for chrome os, where we have the system harfbuzz under
20 # are building for chrome os, where we have the system harfbuzz under 20 # control as well. We also do not want to use the system harfbuzz
21 # control as well. 21 # when cross-compiling for ARM.
22 use_system_harfbuzz = exec_script(pkg_config_script, 22 use_system_harfbuzz = is_linux && (is_chromeos || (!is_official_build &&
23 pkg_config_args + [ 23 current_cpu != "arm")) &&
24 "--atleast-version=1.31.0", 24 exec_script(pkg_config_script,
25 "pangoft2", 25 pkg_config_args + [
26 ], 26 "--atleast-version=1.31.0",
27 "value") 27 "pangoft2",
28 } else { 28 ],
29 use_system_harfbuzz = false 29 "value")
30 }
31 if (is_linux && current_cpu == "arm" && !is_chromeos) {
32 # Override use_system_harfbuzz for ARM cross compiling so system
33 # harfbuzz is not used because the corresponding package is not
34 # available.
35 use_system_harfbuzz = false
36 }
37 } 30 }
38 31
39 if (use_system_harfbuzz) { 32 if (use_system_harfbuzz) {
40 import("//build/config/linux/pkg_config.gni") 33 import("//build/config/linux/pkg_config.gni")
41 pkg_config("harfbuzz_pkgconfig") { 34 pkg_config("harfbuzz_pkgconfig") {
42 packages = [ "harfbuzz" ] 35 packages = [ "harfbuzz" ]
43 } 36 }
44 group("harfbuzz-ng") { 37 group("harfbuzz-ng") {
45 public_configs = [ ":harfbuzz_pkgconfig" ] 38 public_configs = [ ":harfbuzz_pkgconfig" ]
46 } 39 }
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 } 158 }
166 if (is_mac) { 159 if (is_mac) {
167 sources += [ 160 sources += [
168 "src/hb-coretext.cc", 161 "src/hb-coretext.cc",
169 "src/hb-coretext.h", 162 "src/hb-coretext.h",
170 ] 163 ]
171 defines += [ "HAVE_CORETEXT" ] 164 defines += [ "HAVE_CORETEXT" ]
172 } 165 }
173 } 166 }
174 } 167 }
OLDNEW
« no previous file with comments | « ppapi/thunk/BUILD.gn ('k') | third_party/libxml/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698