ppapi/native_client/src/untrusted/pnacl_support_extension/BUILD.gn - Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ppapi/native_client/src/untrusted/pnacl_support_extension/BUILD.gn

Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clean up for review Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ppapi/native_client/src/untrusted/pnacl_irt_shim/BUILD.gn ('K') | « ppapi/native_client/src/untrusted/pnacl_irt_shim/BUILD.gn ('k') | third_party/harfbuzz-ng/BUILD.gn » ('j') | third_party/harfbuzz-ng/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 import("//build/config/features.gni")
	brettw 2015/02/05 00:20:36 Copyright (I'm going to stop commenting on these) Copyright (I'm going to stop commenting on these)
	2

	3 if (enable_nacl && enable_nacl_untrusted && enable_pnacl) {
	Nick Bray (chromium) 2015/02/05 23:21:46 Dito Dito Dirk Pranke 2015/02/05 23:52:19 Will make same fix. Show quoted text On 2015/02/05 23:21:46, Nick Bray (chromium) wrote: > Dito Will make same fix.
	4 group("pnacl_support_extension") {

	5 # TODO(dpranke): implement me ...

	6 }

	7 }

OLD	NEW