ppapi/native_client/src/untrusted/irt_stub/BUILD.gn - Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ppapi/native_client/src/untrusted/irt_stub/BUILD.gn

Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clean up for review Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ppapi/native_client/src/trusted/plugin/BUILD.gn ('K') | « ppapi/native_client/src/trusted/plugin/BUILD.gn ('k') | ppapi/native_client/src/untrusted/pnacl_irt_shim/BUILD.gn » ('j') | ppapi/native_client/src/untrusted/pnacl_irt_shim/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.
	brettw 2015/02/05 00:20:36 2015 2015
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import("//build/config/features.gni")

	6

	7 if (enable_nacl && enable_nacl_untrusted) {
	Nick Bray (chromium) 2015/02/05 23:21:46 Nit: technically not needed? If we're including _ Nit: technically not needed? If we're including _any_ file in the untrusted directory without enable_nacl_untrusted being true, something is seriously wrong. I wouldn't mind leaving this in as a sanity check, however, if you comment it. Dirk Pranke 2015/02/05 23:52:19 This is probably better changed to an assert() the Show quoted text On 2015/02/05 23:21:46, Nick Bray (chromium) wrote: > Nit: technically not needed? If we're including _any_ file in the untrusted > directory without enable_nacl_untrusted being true, something is seriously > wrong. I wouldn't mind leaving this in as a sanity check, however, if you > comment it. This is probably better changed to an assert() then. Will do so. Nick Bray (chromium) 2015/02/06 01:18:00 asserting is_nacl would be the cleanest approach, Show quoted text On 2015/02/05 23:52:19, Dirk Pranke wrote: > On 2015/02/05 23:21:46, Nick Bray (chromium) wrote: > > Nit: technically not needed? If we're including _any_ file in the untrusted > > directory without enable_nacl_untrusted being true, something is seriously > > wrong. I wouldn't mind leaving this in as a sanity check, however, if you > > comment it. > > This is probably better changed to an assert() then. Will do so. asserting is_nacl would be the cleanest approach, I think.
	8 static_library("ppapi_stub_lib") {

	9 sources = [

	10 "ppapi_plugin_main.c",

	11 "ppapi_plugin_start.c",

	12 "plugin_main_irt.c",

	13 "thread_creator.c",

	14 ]

	15 }

	16 }

OLD	NEW