ppapi/native_client/src/untrusted/irt_stub/BUILD.gn - Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ppapi/native_client/src/untrusted/irt_stub/BUILD.gn

Issue 877553008: Land prep work to enable NaCl in the Linux x64 GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge to #317924 Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 assert(is_nacl,

	6 "These targets must only be built using the untrusted NaCl toolchains.")

	7

	8 static_library("ppapi_stub_lib") {
	brettw 2015/02/25 21:27:29 Almost all static libraries in GYP should be conve Almost all static libraries in GYP should be converted to source_set in GN. Some exceptions are if we're distributing the actual static library. Can you check the static libs you added to see if you're sure they need to be static libraries? Dirk Pranke 2015/02/25 21:37:41 Will do. Show quoted text On 2015/02/25 21:27:29, brettw wrote: > Almost all static libraries in GYP should be converted to source_set in GN. Some > exceptions are if we're distributing the actual static library. Can you check > the static libs you added to see if you're sure they need to be static > libraries? Will do.
	9 sources = [

	10 "ppapi_plugin_main.c",

	11 "ppapi_plugin_start.c",

	12 "plugin_main_irt.c",

	13 "thread_creator.c",

	14 ]

	15 }

OLD	NEW

« mojo/nacl/BUILD.gn ('K') | « ppapi/native_client/src/trusted/plugin/BUILD.gn ('k') | ppapi/native_client/src/untrusted/pnacl_irt_shim/BUILD.gn » ('j') | ppapi/proxy/BUILD.gn » ('J')