Land prep work to enable NaCl in the Linux x64 GN builds.

mojo/nacl/BUILD.gn

 # All toolchains use the same generated code.
 gen_dir = "$root_build_dir/gen/mojo/nacl"
 
 # Only allow the generator to be run by one toolchain.
 if (current_toolchain == default_toolchain) {
   # Generate the code to plumb the Mojo public API into the NaCl sandbox.
   action("mojo_nacl_codegen") {
     script = "generator/generate_nacl_bindings.py"
     args = [
       "-d",
       rebase_path(gen_dir, root_build_dir),
     ]
     inputs = [
       script,
       "generator/interface.py",
       "generator/interface_dsl.py",
       "generator/mojo_syscall.cc.tmpl",
       "generator/libmojo.cc.tmpl",
     ]
     outputs = [
       "$gen_dir/mojo_irt.c",
       "$gen_dir/mojo_irt.h",
       "$gen_dir/mojo_syscall.cc",
       "$gen_dir/libmojo.cc",
     ]
+    public_configs =
+        [ "//third_party/mojo/src/mojo/public/build/config:mojo_sdk" ]

[Dirk Pranke, 2015/02/25 21:08:46]

I'm not sure if this is the right way to handle this ...

[brettw, 2015/02/25 21:27:29]

Doesn't look obviously wrong to me.

[Dirk Pranke, 2015/02/25 21:37:40]

Acknowledged.

   }
 }
 
 # Trusted code
 if (!is_nacl) {
   # A library for launching a NaCl sandbox connected to a Mojo embedder.
   static_library("monacl_sel") {
     sources = [
       "mojo_syscall_internal.h",
       "$gen_dir/mojo_syscall.cc",
       "monacl_sel_main.cc",
     ]
+
     deps = [
       # This target makes sure we have all the pre-processor defines needed to
       # use NaCl's headers.
       "//native_client/build/config/nacl:nacl_base",
       "//native_client/src/trusted/desc:nrd_xfer",
       "//native_client/src/trusted/service_runtime:sel_main_chrome",
       ":mojo_nacl_codegen($default_toolchain)",
     ]
   }
 
@@ skipping 14 matching lines @@
 
 # Untrusted code
 if (is_nacl) {
   # Thunk mapping the Mojo public API onto NaCl syscalls.
   static_library("mojo") {
     sources = [
       "$gen_dir/libmojo.cc",
       "$gen_dir/mojo_irt.h",
     ]
     include_dirs = [ "$root_build_dir/gen" ]
-    deps = [
+    public_deps = [
       ":mojo_nacl_codegen($default_toolchain)",
     ]
   }
 
   # Unit test for the Mojo public API.
   executable("monacl_test") {
     testonly = true
     sources = [
       "//third_party/mojo/src/mojo/public/cpp/system/tests/core_unittest.cc",
       "//third_party/mojo/src/mojo/public/cpp/system/tests/macros_unittest.cc",
     ]
+    include_dirs = [ "//third_party/mojo/src" ]

[brettw, 2015/02/25 21:27:29]

We shouldn't have to specify this kind of thing manually. It should come from
some appropriate config. What's the error you're trying to solve?

[Dirk Pranke, 2015/02/25 21:37:40]

Agreed, which is partially why I had the comment above. However, per ncbray we
can actually just delete these targets as they shouldn't be in chromium at all.

     deps = [
       "//testing/gtest:gtest",
       "//testing/gtest:gtest_main",
       "//third_party/mojo/src/mojo/public/c/system/tests:tests",
       "//third_party/mojo/src/mojo/public/cpp/system:system",
       ":mojo",
     ]
   }
 
+  source_set("irt_mojo_sources") {
+    cflags_c = [ "-std=c99" ]
+    sources = [
+      "$gen_dir/mojo_irt.c",
+      "$gen_dir/mojo_irt.h",
+    ]
+    include_dirs = [ "$root_build_dir/gen" ]

[brettw, 2015/02/25 21:27:29]

You can delete this line, it should be there by default.

[Dirk Pranke, 2015/02/25 21:37:41]

It didn't seem to be, but I'll double check. Maybe I misred the error somewhere.

+    public_deps = [
+      "//native_client/build/config/nacl:nacl_base",
+      "//native_client/src/untrusted/irt:irt_core_lib",
+      "//native_client/src/untrusted/nacl:imc_syscalls",
+      ":mojo_nacl_codegen($default_toolchain)",
+    ]
+  }
+
   executable("irt_mojo") {
     cflags_c = [ "-std=c99" ]
     sources = [
       "irt_entry_mojo.c",
-      "$gen_dir/mojo_irt.c",
-      "$gen_dir/mojo_irt.h",
     ]
     include_dirs = [ "$root_build_dir/gen" ]
     deps = [
-      "//native_client/build/config/nacl:nacl_base",
-      "//native_client/src/untrusted/irt:irt_core_lib",
-      "//native_client/src/untrusted/nacl:imc_syscalls",
-      ":mojo_nacl_codegen($default_toolchain)",
+      ":irt_mojo_sources",
     ]
   }
 }
 
 group("mojo_nacl") {
   deps = [
     ":irt_mojo(//native_client/build/toolchain/nacl:irt_${current_cpu})",
   ]
 }
 
 group("mojo_nacl_tests") {
   testonly = true
   deps = [
     ":monacl_shell",
     ":monacl_test(//native_client/build/toolchain/nacl:clang_newlib_${current_cpu})",
   ]
 }