Source/core/rendering/svg/RenderSVGShape.h - Issue 877553002: Fix ellipse hit testing in the non-circle case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGShape.h

Issue 877553002: Fix ellipse hit testing in the non-circle case (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Lazily create the path Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/RenderSVGShape.h

diff --git a/Source/core/rendering/svg/RenderSVGShape.h b/Source/core/rendering/svg/RenderSVGShape.h

index 2a6c12cfe141e43c6ed6895dfdee019c36baabc1..39045dc97d202ad8f46aca97fb7f64f0aea18550 100644

--- a/Source/core/rendering/svg/RenderSVGShape.h

+++ b/Source/core/rendering/svg/RenderSVGShape.h

@@ -80,6 +80,8 @@ public:

virtual FloatRect objectBoundingBox() const override final { return m_fillBoundingBox; }

protected:

+ void clearPath() { m_path.clear(); }

virtual void updateShapeFromElement();

virtual bool shapeDependentStrokeContains(const FloatPoint&);

virtual bool shapeDependentFillContains(const FloatPoint&, const WindRule) const;