Chromium Code Reviews| Index: Source/bindings/templates/methods.cpp |
| diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp |
| index 5b62e398e8ad8e691c54d73eb67f38505ea21679..b6483d18a288db860c9b37b5a6c90611eeee43a8 100644 |
| --- a/Source/bindings/templates/methods.cpp |
| +++ b/Source/bindings/templates/methods.cpp |
| @@ -375,7 +375,7 @@ static void {{overloads.name}}Method{{world_suffix}}(const v8::FunctionCallbackI |
| method.runtime_enabled_function) %} |
| if ({{test}}) { |
| {% if method.measure_as and not overloads.measure_all_as %} |
| - UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::{{method.measure_as}}); |
| + UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::{{method.measure_as('Overload%d' % method.overload_index)}}); |
|
Jens Widell
2015/01/26 07:14:48
This seems somewhat problematic to me; what a meth
dstockwell
2015/01/26 07:26:48
That seems a reasonable solution for overloads. Ch
|
| {% endif %} |
| {% if method.deprecate_as and not overloads.deprecate_all_as %} |
| UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::{{method.deprecate_as}}); |
| @@ -434,7 +434,7 @@ static void {{method.name}}MethodCallback{{world_suffix}}(const v8::FunctionCall |
| TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMMethod"); |
| {% if not method.overloads %}{# Overloaded methods are measured in overload_resolution_method() #} |
| {% if method.measure_as %} |
| - UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::{{method.measure_as}}); |
| + UseCounter::countIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::{{method.measure_as('Method')}}); |
| {% endif %} |
| {% if method.deprecate_as %} |
| UseCounter::countDeprecationIfNotPrivateScript(info.GetIsolate(), callingExecutionContext(info.GetIsolate()), UseCounter::{{method.deprecate_as}}); |