Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
877513002:
Add a test for a simulated click on a link. (Closed)
|
Created:
5 years, 11 months ago by Miyoung Shin Modified:
5 years, 10 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd a test for a simulated click on a link.
When the Ctrl+Enter are pressed, the click is simulated.
The test checks if the new tab is opened on the background.
BUG=450069
R=jochen@chromium.org
Committed: https://crrev.com/12ac7fa80a561b19ac68a471cfca410591dc7164
Cr-Commit-Position: refs/heads/master@{#314313}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #Patch Set 5 : #
Messages
Total messages: 27 (9 generated)
jochen@, I couldn't add the test in popup_blocker_browsertest.cc you suggested because browser_tests doesn't include SendKeyPress . so I added the test in BrowserKeyEventsTest of interactive_ui_tests. PTAL.
you can use RenderViewHost::ForwardKeyboardEvent to send a simulated key event to the renderer. interactive ui tests are only required to interact with native UI
On 2015/01/26 15:49:39, jochen (slow) wrote: > you can use RenderViewHost::ForwardKeyboardEvent to send a simulated key event > to the renderer. interactive ui tests are only required to interact with native > UI I got it. I will try to use RenderViewHost::ForwardKeyboardEvent. Thank you for your information.
Patchset #2 (id:20001) has been deleted
jochen@, I've uploaded the new patch. PTAL.
lgtm
The CQ bit was checked by myid.shin@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877513002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #3 (id:60001) has been deleted
On 2015/01/29 02:56:07, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > mac_chromium_rel_ng on tryserver.chromium.mac > (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) jochen@, I've disabled the test on only OSX. I'm not sure but it seems it's flaky on OSX. Can I land it if you are ok with that ?
it's kinda of odd that this fails on mac. Can you verify that the behavior is actually correct on mac as well?
On 2015/01/29 16:52:57, jochen (slow) wrote: > it's kinda of odd that this fails on mac. Can you verify that the behavior is > actually correct on mac as well? OK, I'm not familiar with Mac but, I will try.
I verified that in M40, Cmd-Enter doesn't work on mac either. So the test is good as is.
On 2015/02/01 19:07:39, jochen (slow) wrote: > I verified that in M40, Cmd-Enter doesn't work on mac either. So the test is > good as is. As I checked, it is caused by no getting keyUp event from OSX when pressing Cmd-Enter. But this test makes the key event internally and I could add the test without any dependency of OS.
even better, lgtm!
Patchset #6 (id:140001) has been deleted
Patchset #5 (id:120001) has been deleted
The CQ bit was checked by myid.shin@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877513002/160001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (None)
The CQ bit was checked by myid.shin@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877513002/160001
Message was sent while issue was closed.
Committed patchset #5 (id:160001)
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/12ac7fa80a561b19ac68a471cfca410591dc7164 Cr-Commit-Position: refs/heads/master@{#314313} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
