This fixes bug http://code.google.com/p/chromium/issues/detail?id=3881, which...

This fixes bug http://code.google.com/p/chromium/issues/detail?id=3881, which
was NPAPI plugin UI test failures. This occured as a sideeffect of the webkit
merge. Some functions in widget.h which were implemented by WebPluginContainer
no longer exist. We need to implement their replacements on similar lines.

Bug=3881
R=jam


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4343

[jam, 2008-10-31 20:11:48]

http://codereview.chromium.org/8775/diff/5/205
File webkit/glue/webplugin_impl.cc (right):

http://codereview.chromium.org/8775/diff/5/205#newcode194
Line 194: impl_->setFrameRect(frameRect());
shouldn't we call the parent function too?  (I know that the Widget
implementation is empty now, but can we always assume that?)

Also, this code is duplicated from WebPluginImpl::geometryChanged().  is that
function still needed?

http://codereview.chromium.org/8775/diff/5/205#newcode198
Line 198: WebCore::Widget::setParentVisible(visible);
do we still need to implement show() and hide()?  if they're called by Webkit,
then this function isn't necessary.  if they're not called, then we can remove
them, no?

[ananta, 2008-10-31 21:01:31]

Hi John

We still need to implement show and hide as we need to show/hide the plugin in
certain cases. Please look at revision 36534 which references bug
http://b/issue?id=1055768. This was a case where the containing iframe would be
hidden and the plugin would continue to be visible. Our implementation is on
similar lines as Webkit's plugin implementation. 

CB updated.

Thanks
Ananta


On 2008/10/31 20:11:48, John Abd-El-Malek wrote:
> http://codereview.chromium.org/8775/diff/5/205
> File webkit/glue/webplugin_impl.cc (right):
> 
> http://codereview.chromium.org/8775/diff/5/205#newcode194
> Line 194: impl_->setFrameRect(frameRect());
> shouldn't we call the parent function too?  (I know that the Widget
> implementation is empty now, but can we always assume that?)
> 
> Also, this code is duplicated from WebPluginImpl::geometryChanged().  is that
> function still needed?
> 
> http://codereview.chromium.org/8775/diff/5/205#newcode198
> Line 198: WebCore::Widget::setParentVisible(visible);
> do we still need to implement show() and hide()?  if they're called by Webkit,
> then this function isn't necessary.  if they're not called, then we can remove
> them, no?

[jam, 2008-10-31 23:11:51]

latest snapshot lgtm

http://codereview.chromium.org/8775/diff/16/219
File webkit/glue/webplugin_impl.h (right):

http://codereview.chromium.org/8775/diff/16/219#newcode68
Line 68: // We override this function, to make sure that geometry updates are
sent
can this comment be moved to the implementation?  also no need to repeat
"geometry update is sent over to the plugin." twice in the beginning and end.