chrome/browser/ui/views/exclusive_access_bubble_views.h - Issue 877413004: Refactor away the Browser* dependency in exclusive_access

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/exclusive_access_bubble_views.h

Issue 877413004: Refactor away the Browser* dependency in exclusive_access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update based on CR comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/exclusive_access/fullscreen_controller.cc ('K') | « chrome/browser/ui/exclusive_access/mouse_lock_controller.cc ('k') | chrome/browser/ui/views/exclusive_access_bubble_views.cc » ('j') | chrome/browser/ui/views/exclusive_access_bubble_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/exclusive_access_bubble_views.h

diff --git a/chrome/browser/ui/views/exclusive_access_bubble_views.h b/chrome/browser/ui/views/exclusive_access_bubble_views.h

index 5b187bd3e95a89e435c78e4a23f21d4eea3315b3..122c07dae4854eb7f9a4978566dd88af17efc1d0 100644

--- a/chrome/browser/ui/views/exclusive_access_bubble_views.h

+++ b/chrome/browser/ui/views/exclusive_access_bubble_views.h

@@ -12,7 +12,7 @@

#include "content/public/browser/notification_registrar.h"

#include "ui/views/widget/widget_observer.h"

-class BrowserView;

+class ExclusiveAccessBubbleViewsContext;

class GURL;

namespace gfx {

class SlideAnimation;

@@ -30,7 +30,7 @@ class ExclusiveAccessBubbleViews : public ExclusiveAccessBubble,

public content::NotificationObserver,

public views::WidgetObserver {

public:

- ExclusiveAccessBubbleViews(BrowserView* browser,

+ ExclusiveAccessBubbleViews(ExclusiveAccessBubbleViewsContext* context,

const GURL& url,

ExclusiveAccessBubbleType bubble_type);

~ExclusiveAccessBubbleViews() override;

@@ -82,7 +82,7 @@ class ExclusiveAccessBubbleViews : public ExclusiveAccessBubble,

// views::WidgetObserver override:

void OnWidgetVisibilityChanged(views::Widget* widget, bool visible) override;

- BrowserView* browser_view_;

+ ExclusiveAccessBubbleViewsContext* bubble_view_context_;

views::Widget* popup_;