Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3906)

Unified Diff: chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm

Issue 877413004: Refactor away the Browser* dependency in exclusive_access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update based on CR comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm b/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm
index d86010685799696c0a4444022c0cbf4299d8d06d..b3520045f00fc238b9418461c606a0d6a3bb0965 100644
--- a/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/exclusive_access_bubble_window_controller_unittest.mm
@@ -61,11 +61,12 @@ class ExclusiveAccessBubbleWindowControllerTest : public CocoaProfileTest {
site_instance_ = SiteInstance::Create(profile());
controller_.reset([[ExclusiveAccessBubbleWindowController alloc]
- initWithOwner:nil
- browser:browser()
- url:GURL()
- bubbleType:
- EXCLUSIVE_ACCESS_BUBBLE_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION]);
+ initWithOwner:nil
+ exclusive_access_manager:browser()->exclusive_access_manager()
+ profile:browser()->profile()
+ url:GURL()
+ bubbleType:
+ EXCLUSIVE_ACCESS_BUBBLE_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION]);
EXPECT_TRUE([controller_ window]);
}
@@ -143,20 +144,23 @@ TEST_F(ExclusiveAccessBubbleWindowControllerTest, ShortcutText) {
// http://crbug.com/139944
TEST_F(ExclusiveAccessBubbleWindowControllerTest, DenyButtonText) {
controller_.reset([[ExclusiveAccessBubbleWindowController alloc]
- initWithOwner:nil
- browser:browser()
- url:GURL()
- bubbleType:EXCLUSIVE_ACCESS_BUBBLE_TYPE_MOUSELOCK_BUTTONS]);
+ initWithOwner:nil
+ exclusive_access_manager:browser()->exclusive_access_manager()
+ profile:browser()->profile()
+ url:GURL()
+ bubbleType:EXCLUSIVE_ACCESS_BUBBLE_TYPE_MOUSELOCK_BUTTONS]);
[controller_ initializeLabelAndButton];
NSString* mouselock_deny_button_text = [controller_ denyButtonText];
EXPECT_NSEQ(l10n_util::GetNSString(IDS_FULLSCREEN_DENY),
mouselock_deny_button_text);
controller_.reset([[ExclusiveAccessBubbleWindowController alloc]
- initWithOwner:nil
- browser:browser()
- url:GURL()
- bubbleType:EXCLUSIVE_ACCESS_BUBBLE_TYPE_FULLSCREEN_MOUSELOCK_BUTTONS]);
+ initWithOwner:nil
+ exclusive_access_manager:browser()->exclusive_access_manager()
+ profile:browser()->profile()
+ url:GURL()
+ bubbleType:
+ EXCLUSIVE_ACCESS_BUBBLE_TYPE_FULLSCREEN_MOUSELOCK_BUTTONS]);
[controller_ initializeLabelAndButton];
NSString* fullscreen_mouselock_deny_button_text =
[controller_ denyButtonText];

Powered by Google App Engine
This is Rietveld 408576698