Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: chrome/browser/ui/exclusive_access/exclusive_access_bubble.h

Issue 877413004: Refactor away the Browser* dependency in exclusive_access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix broken mac change Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/exclusive_access/exclusive_access_bubble.h
diff --git a/chrome/browser/ui/exclusive_access/exclusive_access_bubble.h b/chrome/browser/ui/exclusive_access/exclusive_access_bubble.h
index d7654abdb973af213299a17571aaa49826cabfbe..57f55c0c7a1decd1c63e171690c9be1560a2d4b5 100644
--- a/chrome/browser/ui/exclusive_access/exclusive_access_bubble.h
+++ b/chrome/browser/ui/exclusive_access/exclusive_access_bubble.h
@@ -11,7 +11,7 @@
#include "ui/gfx/geometry/point.h"
#include "url/gurl.h"
-class Browser;
+class ExclusiveAccessManager;
namespace gfx {
class Rect;
@@ -22,7 +22,7 @@ class Rect;
// state, namely fullscreen and mouse lock.
class ExclusiveAccessBubble : public gfx::AnimationDelegate {
public:
- explicit ExclusiveAccessBubble(Browser* browser,
+ explicit ExclusiveAccessBubble(ExclusiveAccessManager* manager,
const GURL& url,
ExclusiveAccessBubbleType bubble_type);
~ExclusiveAccessBubble() override;
@@ -71,7 +71,7 @@ class ExclusiveAccessBubble : public gfx::AnimationDelegate {
// on or off the screen as appropriate.
void CheckMousePosition();
- void ToggleFullscreen();
+ void ExitExclusiveAccess();
// Accepts the request. Can cause FullscreenExitBubble to be deleted.
void Accept();
// Denys the request. Can cause FullscreenExitBubble to be deleted.
@@ -85,8 +85,8 @@ class ExclusiveAccessBubble : public gfx::AnimationDelegate {
// The following strings never change.
base::string16 GetInstructionText() const;
- // The browser this bubble is in.
- Browser* browser_;
+ // The Manager associated with this bubble.
+ ExclusiveAccessManager* const manager_;
// The host the bubble is for, can be empty.
GURL url_;

Powered by Google App Engine
This is Rietveld 408576698