Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5180)

Unified Diff: chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h

Issue 877413004: Refactor away the Browser* dependency in exclusive_access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename toggle fullscreen function Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h
diff --git a/chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h b/chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h
index 99c561426df9d497439b0f73108a37364bf1147d..1d127c4a6f540c6d22970c5a89b144282ff61581 100644
--- a/chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h
+++ b/chrome/browser/ui/exclusive_access/exclusive_access_controller_base.h
@@ -6,13 +6,11 @@
#define CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_EXCLUSIVE_ACCESS_CONTROLLER_BASE_H_
#include "base/basictypes.h"
-#include "base/memory/weak_ptr.h"
+#include "base/memory/ref_counted.h"
#include "chrome/browser/ui/exclusive_access/exclusive_access_bubble_type.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
-class Browser;
-class BrowserWindow;
class ExclusiveAccessManager;
class GURL;
class Profile;
@@ -26,8 +24,7 @@ class WebContents;
// which the resource (screen/mouse) is held exclusively.
class ExclusiveAccessControllerBase : public content::NotificationObserver {
public:
- explicit ExclusiveAccessControllerBase(ExclusiveAccessManager* manager,
- Browser* browser);
+ explicit ExclusiveAccessControllerBase(ExclusiveAccessManager* manager);
~ExclusiveAccessControllerBase() override;
GURL GetExclusiveAccessBubbleURL() const;
@@ -73,10 +70,6 @@ class ExclusiveAccessControllerBase : public content::NotificationObserver {
ExclusiveAccessManager* exclusive_access_manager() const { return manager_; }
- Browser* browser() const { return browser_; }
-
- Profile* profile() const { return profile_; }
-
// Exits exclusive access mode for the tab if currently exclusive.
virtual void ExitExclusiveAccessIfNecessary() = 0;
@@ -88,8 +81,6 @@ class ExclusiveAccessControllerBase : public content::NotificationObserver {
void UpdateNotificationRegistrations();
ExclusiveAccessManager* const manager_;
- Browser* const browser_;
- Profile* const profile_;
content::NotificationRegistrar registrar_;

Powered by Google App Engine
This is Rietveld 408576698