Refactor away the Browser* dependency in exclusive_access

chrome/browser/ui/exclusive_access/exclusive_access_context.h

+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+#ifndef CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_EXCLUSIVE_ACCESS_CONTEXT_H_
+#define CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_EXCLUSIVE_ACCESS_CONTEXT_H_
+
+#include "chrome/browser/ui/exclusive_access/exclusive_access_bubble_type.h"
+
+class GURL;
+class Profile;
+
+namespace content {
+class WebContents;
+}
+
+// Context in which exclusive access operation is being performed. This
+// interface is implemented once in Browser context and in Platform Application
+// context.
+class ExclusiveAccessContext {
+ public:
+  virtual ~ExclusiveAccessContext() {}
+
+  // Returns the current profile associated with the window.
+  virtual Profile* GetProfile() = 0;
+
+  // Returns true if the window hosting the exclusive access bubble is
+  // fullscreen.
+  virtual bool IsFullscreen() const = 0;
+
+  // Returns true if the window host the exclusive access bubble is fullscreen.

[scheib, 2015/02/25 19:30:13]

This comment needs fixing. BrowserWindow::IsFullscreenWithToolbar documents
generally what this is, though even that could be clearer. The other comments in
this interface also reference this concept a bit. I suggest:

Returns true if the window is fullscreen with additional UI elements. See
EnterFullscreen |with_toolbar|.

[Sriram, 2015/02/25 21:53:27]

Done.

+  virtual bool IsFullscreenWithToolbar() const = 0;
+
+  // Methods that change fullscreen state.

[scheib, 2015/02/25 19:30:13]

"Methods that change fullscreen state" -> "Enter fullscreen and update exit
bubble."

[Sriram, 2015/02/25 21:53:27]

Done.

+  // On Mac, the tab strip and toolbar will be shown if |with_toolbar| is true,
+  // |with_toolbar| is ignored on other platforms.
+  virtual void EnterFullscreen(const GURL& url,
+                               ExclusiveAccessBubbleType bubble_type,
+                               bool with_toolbar) = 0;
+
+  // Exits fullscreen and update exit bubble.
+  virtual void ExitFullscreen() = 0;
+
+  // Updates the content of exclusive access exit bubble content.
+  virtual void UpdateExclusiveAccessExitBubbleContent(
+      const GURL& url,
+      ExclusiveAccessBubbleType bubble_type) = 0;
+
+  // Returns the currently active WebContents, or nullptr if there is none.
+  virtual content::WebContents* GetActiveWebContents() = 0;
+
+  // Returns true if fullscreen with toolbar is supported.
+  virtual bool SupportsFullscreenWithToolbar() const;

[scheib, 2015/02/25 19:30:13]

Move Supports____ and Update___ just above IsFullscreenWithToolbar() (and move
all impl files to maintain consistent ordering...)

[Sriram, 2015/02/25 21:53:27]

Done.

+
+  // Shows or hides the tab strip, toolbar and bookmark bar with in browser
+  // fullscreen.
+  // Currently only supported on Mac.
+  virtual void UpdateFullscreenWithToolbar(bool with_toolbar);
+
+  // Sets state for entering or exiting Win8 Metro snap mode.

[scheib, 2015/02/25 19:30:13]

Wrap in #if defined(OS_WIN) as is done elsewhere to make it clear this is only
Windows.

[Sriram, 2015/02/25 21:53:27]

Done.

+  virtual void SetMetroSnapMode(bool enable);
+
+  // Returns whether the window is currently in Win8 Metro snap mode.
+  virtual bool IsInMetroSnapMode() const;
+
+  // Shows or hides download shelf associated with currently active window.
+  virtual void UpdateDownloadShelf(bool unhide);

[scheib, 2015/02/25 19:30:13]

The naming is and readability suffers (have to look at declaration to understand
what Update(false) means. Split to two methods
HideDownloadShelf
UnhideDownloadShelf

[Sriram, 2015/02/25 21:53:27]

Done.

+};
+
+#endif  // CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_EXCLUSIVE_ACCESS_CONTEXT_H_