Refactor away the Browser* dependency in exclusive_access

chrome/browser/ui/exclusive_access/exclusive_access_context.h

+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+#ifndef CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_EXCLUSIVE_ACCESS_CONTEXT_H_
+#define CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_EXCLUSIVE_ACCESS_CONTEXT_H_
+
+#include "chrome/browser/ui/exclusive_access/exclusive_access_bubble_type.h"
+
+class GURL;
+class Profile;
+
+namespace content {
+class WebContents;
+}
+
+// Context in which exclusive access operation is being performed. This
+// interface is implemented once in Browser context and in Platform Application
+// context.
+class ExclusiveAccessContext {

[scheib, 2015/02/10 23:12:03]

I think I'm preferring the Delegate pattern where this interface is used as a
base class for Browser and AppWindow instead of having
ExclusiveAccessContextBrowser adapters.

[Sriram, 2015/02/10 23:44:46]

Yuri had same suggestion. It would be BrowserWindow and AppWindow. I will do
that.

On 2015/02/10 23:12:03, scheib wrote:

+ public:
+  virtual ~ExclusiveAccessContext() {}
+
+  // Returns the current profile associated with the window.
+  virtual Profile* GetProfile() = 0;

[scheib, 2015/02/10 23:12:03]

Profile* won't work in extensions, it will need to be BrowserContext. But that
doesn't have GetHostContentSettingsmap or GetPrefs.

[Sriram, 2015/02/10 23:44:46]

I thought I could go from BrowserContext to Profile using
Profile::FromBrowserContext() but that was before I realized that AppWindow
cannot depend on chrome code. Ben? 

On 2015/02/10 23:12:03, scheib wrote:

[scheib, 2015/02/11 00:05:55]

Ah, yes, so long as the code accessing is in chrome, you can get back to
Profile. This implies that the EACFullscreen and MouseLock classes remain in
chrome/browser

[Sriram, 2015/02/25 00:41:23]

Acknowledged.

+
+  // Returns true if the window hosting the exclusive access bubble is
+  // fullscreen.
+  virtual bool IsFullscreen() = 0;

[scheib, 2015/02/10 23:12:03]

Most of these methods so far are Fullscreen related. Those won't be used in
AppWindow AFAIK because ExclusiveAccessController isn't used there at all.

What's the plan with keyboard? Will members such as this be necessary for
keyboard?

It appears no methods are specific to mouse lock.

So then I wonder if either the fullscreen related bits should be pulled out to
another interface and just not implemented at all by AppWindow, or if all these
methods should have default impl with NOT_IMPLEMENTED.

[Sriram, 2015/02/10 23:44:46]

I was planning to use ExclusiveAccessController as such but not hook-up calls
needed to actually enable fullscreen/mouselock controller. There was a some
scenarios under which AppWindow wanted to use them (once again Ben?), and when
they are hooked up it will behave correctly with keyboard lock. 

On 2015/02/10 23:12:03, scheib wrote:

+
+  // Returns true if the window host the exclusive access bubble is fullscreen.
+  virtual bool IsFullscreenWithToolbar() = 0;
+
+  // Returns true if fullscreen with toolbar is supported.
+  virtual bool SupportsFullscreenWithToolbar() = 0;
+
+  // Methods that change fullscreen state.
+  // On Mac, the tab strip and toolbar will be shown if |with_toolbar| is true,
+  // |with_toolbar| is ignored on other platforms.
+  virtual void EnterFullscreen(const GURL& url,
+                               ExclusiveAccessBubbleType bubble_type,
+                               bool with_toolbar) = 0;
+  virtual void ExitFullscreen() = 0;
+  // Updates the content of exclusive access exit bubble content.
+  virtual void UpdateExclusiveAccessExitBubbleContent(
+      GURL url,
+      ExclusiveAccessBubbleType bubble_type) = 0;
+
+  // Returns the currently active WebContents, or nullptr if there is none.
+  virtual content::WebContents* GetActiveWebContents() = 0;
+
+  // Shows or hides the tab strip, toolbar and bookmark bar with in browser
+  // fullscreen.
+  // Currently only supported on Mac.
+  virtual void UpdateFullscreenWithToolbar(bool with_toolbar) = 0;
+
+  // Sets state for entering or exiting Win8 Metro snap mode.
+  virtual void SetMetroSnapMode(bool enable) = 0;
+
+  // Returns whether the window is currently in Win8 Metro snap mode.
+  virtual bool IsInMetroSnapMode() = 0;
+
+  // Shows or hides download shelf associated with currently active window.
+  virtual void UpdateDownloadShelf(bool unhide) = 0;
+};
+
+#endif  // CHROME_BROWSER_UI_EXCLUSIVE_ACCESS_EXCLUSIVE_ACCESS_CONTEXT_H_