content/common/gpu/gpu_messages.h - Issue 877353002: media: VideoFrame: add offset for shared memory buffers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/gpu_messages.h

Issue 877353002: media: VideoFrame: add offset for shared memory buffers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add gpu-process ipc modification Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/client/gpu_video_encode_accelerator_host.cc ('K') | « content/common/gpu/client/gpu_video_encode_accelerator_host.cc ('k') | content/common/gpu/media/gpu_video_encode_accelerator.h » ('j') | content/common/gpu/media/gpu_video_encode_accelerator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/gpu_messages.h

diff --git a/content/common/gpu/gpu_messages.h b/content/common/gpu/gpu_messages.h

index 09bc8774ea0d42e9d744ba085eeadb0153850e20..33ed3270033410672b75aadc12d6e9b747169cdb 100644

--- a/content/common/gpu/gpu_messages.h

+++ b/content/common/gpu/gpu_messages.h

@@ -709,9 +709,10 @@ IPC_MESSAGE_ROUTED1(AcceleratedVideoDecoderHostMsg_ErrorNotification,

// Queue a input buffer to the encoder to encode. |frame_id| will be returned by

// AcceleratedVideoEncoderHostMsg_NotifyInputDone.

-IPC_MESSAGE_ROUTED4(AcceleratedVideoEncoderMsg_Encode,

+IPC_MESSAGE_ROUTED5(AcceleratedVideoEncoderMsg_Encode,

int32 /* frame_id */,

base::SharedMemoryHandle /* buffer_handle */,

+ uint32 /* buffer_offset */,

DaleCurtis 2015/01/30 18:44:59 This seems dangerous...

llandwerlin-old 2015/01/31 22:42:53 Can you explain why you think this could be danger

DaleCurtis 2015/02/02 19:24:18 An attacker controls both the buffer_offset and bu

uint32 /* buffer_size */,

bool /* force_keyframe */)