Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 877343008: Unify GPU raster and accelerated canvas blacklists on Android. (Closed)

Created:
5 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
5 years, 10 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, Justin Novosad, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify GPU raster and accelerated canvas blacklists on Android. Accelerated canvas and GPU raster both use the same Skia codepaths and have generally displayed the same bugs. It doesn't make sense to blacklist one but not the other. Since GPU raster sees more usage than canvas nowadays, and I researched GPU raster compatibility as part of https://codereview.chromium.org/760053003, it makes sense to fold canvas into the same blacklist. This immediately fixes an Adreno 225 canvas bug which slipped through a driver-reported-version based blacklist, which is apparently unreliable and which I deleted in this patch. More generally it also should avoid this kind of issue in the future. BUG=453283 NOTRY=true Committed: https://crrev.com/044dfb80b1f612f3c84b35182db0f9b4d93e086c Cr-Commit-Position: refs/heads/master@{#313813}

Patch Set 1 #

Patch Set 2 : Update version number #

Total comments: 2

Patch Set 3 : Code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -21 lines) Patch
M gpu/config/software_rendering_list_json.cc View 1 2 5 chunks +7 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
aelias_OOO_until_Jul13
PTAL.
5 years, 10 months ago (2015-01-29 20:41:13 UTC) #2
Zhenyao Mo
LGTM with a nit https://codereview.chromium.org/877343008/diff/20001/gpu/config/software_rendering_list_json.cc File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/877343008/diff/20001/gpu/config/software_rendering_list_json.cc#newcode1098 gpu/config/software_rendering_list_json.cc:1098: "description": "GPU rasterization is blacklisted ...
5 years, 10 months ago (2015-01-29 22:42:50 UTC) #3
aelias_OOO_until_Jul13
https://codereview.chromium.org/877343008/diff/20001/gpu/config/software_rendering_list_json.cc File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/877343008/diff/20001/gpu/config/software_rendering_list_json.cc#newcode1098 gpu/config/software_rendering_list_json.cc:1098: "description": "GPU rasterization is blacklisted on Nexus 10", On ...
5 years, 10 months ago (2015-01-29 22:44:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877343008/40001
5 years, 10 months ago (2015-01-29 22:51:42 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-29 22:52:38 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/044dfb80b1f612f3c84b35182db0f9b4d93e086c Cr-Commit-Position: refs/heads/master@{#313813}
5 years, 10 months ago (2015-01-29 22:53:25 UTC) #8
aelias_OOO_until_Jul13
5 years, 10 months ago (2015-02-03 01:38:27 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/895673004/ by aelias@chromium.org.

The reason for reverting is: Causes blank screen on Daisy boot (ChromeOS T604).

Powered by Google App Engine
This is Rietveld 408576698