Implement 3-stage minimize animation for Panels on OSX.

Implement 3-stage minimize animation for Panels on OSX.

Fast close to titlebar only -> pause on titlebar-only -> slow minimize.

Also, moved close button 1 px lower so it doesn't show up when panel is minimized.

BUG=104645
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112746

[Dmitry Titov, 2011-12-02 05:15:01]

To keep it simple, this is OSX-only patch, Win is coming as separate one.

[jianli, 2011-12-02 06:18:32]

http://codereview.chromium.org/8773030/diff/1001/chrome/browser/ui/panels/pan...
File chrome/browser/ui/panels/panel_window_controller_cocoa.mm (right):

http://codereview.chromium.org/8773030/diff/1001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:462:
(windowShim_->TitleOnlyHeight() - NSHeight(frame)) / distanceY;
Is NSHeight(frame) for the height of the expanded panel? If so,
titlebarToFrameProportion seens to be a negative value.

http://codereview.chromium.org/8773030/diff/1001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:490: if (progress <=
kAnimationStopAfterQuickDecrease)
nit: better to add brackets.

[Dmitry Titov, 2011-12-02 06:47:09]

http://codereview.chromium.org/8773030/diff/1001/chrome/browser/ui/panels/pan...
File chrome/browser/ui/panels/panel_window_controller_cocoa.mm (right):

http://codereview.chromium.org/8773030/diff/1001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:462:
(windowShim_->TitleOnlyHeight() - NSHeight(frame)) / distanceY;
On 2011/12/02 06:18:32, jianli wrote:
> Is NSHeight(frame) for the height of the expanded panel? If so,
> titlebarToFrameProportion seens to be a negative value.

The |frame| here is a new frame, since we are minimizing it's 4-px one. The
|currentFrame| is the previous one.

I need to subtract the new frame to obtain exact ratio when stopped animation
would only show the titlebar. Updated name of variable in hope to be more
descriptive.

http://codereview.chromium.org/8773030/diff/1001/chrome/browser/ui/panels/pan...
chrome/browser/ui/panels/panel_window_controller_cocoa.mm:490: if (progress <=
kAnimationStopAfterQuickDecrease)
On 2011/12/02 06:18:32, jianli wrote:
> nit: better to add brackets.

Done.

[jianli, 2011-12-02 18:28:18]

lgtm