Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 877283005: Instrumented libraries: do not leave unnecessary files in the product dir. (Closed)

Created:
5 years, 10 months ago by earthdok
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrumented libraries: do not leave unnecessary files in the product dir. - Only copy the lib/ dir (i.e. skip usr/ etc), - Pass --disable-static to configure scripts to avoid building static libs. Ideally, this flag should be in target_defaults. However, zlib1g doesn't support it and fails; I couldn't find a way to exclude the flag for individual packages. Instead I add it to every other package expiclitly. BUG=423343 R=glider@chromium.org NOTRY=true Committed: https://crrev.com/9900a1f1f1e4222e9e4e23271b3a3c28ba827f93 Cr-Commit-Position: refs/heads/master@{#314580}

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -22 lines) Patch
M third_party/instrumented_libraries/download_build_install.py View 3 chunks +12 lines, -9 lines 0 comments Download
M third_party/instrumented_libraries/instrumented_libraries.gyp View 1 37 chunks +82 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
earthdok
5 years, 10 months ago (2015-02-04 17:41:22 UTC) #1
Alexander Potapenko
I don't really like adding --disable-static to every packet config. Per offline discussion I understood ...
5 years, 10 months ago (2015-02-04 17:50:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877283005/20001
5 years, 10 months ago (2015-02-04 18:00:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 18:01:41 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 18:02:42 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9900a1f1f1e4222e9e4e23271b3a3c28ba827f93
Cr-Commit-Position: refs/heads/master@{#314580}

Powered by Google App Engine
This is Rietveld 408576698