Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/x87/macro-assembler-x87.cc

Issue 877243004: Load callback data from weak cell instead of embedding it in handler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x87/macro-assembler-x87.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/base/division-by-constant.h" 10 #include "src/base/division-by-constant.h"
(...skipping 2370 matching lines...) Expand 10 before | Expand all | Expand 10 after
2381 } 2381 }
2382 2382
2383 2383
2384 void MacroAssembler::CmpWeakValue(Register value, Handle<WeakCell> cell, 2384 void MacroAssembler::CmpWeakValue(Register value, Handle<WeakCell> cell,
2385 Register scratch) { 2385 Register scratch) {
2386 mov(scratch, cell); 2386 mov(scratch, cell);
2387 cmp(value, FieldOperand(scratch, WeakCell::kValueOffset)); 2387 cmp(value, FieldOperand(scratch, WeakCell::kValueOffset));
2388 } 2388 }
2389 2389
2390 2390
2391 void MacroAssembler::GetWeakValue(Register value, Handle<WeakCell> cell) {
2392 mov(value, cell);
2393 mov(value, FieldOperand(value, WeakCell::kValueOffset));
2394 }
2395
2396
2391 void MacroAssembler::LoadWeakValue(Register value, Handle<WeakCell> cell, 2397 void MacroAssembler::LoadWeakValue(Register value, Handle<WeakCell> cell,
2392 Label* miss) { 2398 Label* miss) {
2393 mov(value, cell); 2399 GetWeakValue(value, cell);
2394 mov(value, FieldOperand(value, WeakCell::kValueOffset));
2395 JumpIfSmi(value, miss); 2400 JumpIfSmi(value, miss);
2396 } 2401 }
2397 2402
2398 2403
2399 void MacroAssembler::Ret() { 2404 void MacroAssembler::Ret() {
2400 ret(0); 2405 ret(0);
2401 } 2406 }
2402 2407
2403 2408
2404 void MacroAssembler::Ret(int bytes_dropped, Register scratch) { 2409 void MacroAssembler::Ret(int bytes_dropped, Register scratch) {
(...skipping 809 matching lines...) Expand 10 before | Expand all | Expand 10 after
3214 if (mag.shift > 0) sar(edx, mag.shift); 3219 if (mag.shift > 0) sar(edx, mag.shift);
3215 mov(eax, dividend); 3220 mov(eax, dividend);
3216 shr(eax, 31); 3221 shr(eax, 31);
3217 add(edx, eax); 3222 add(edx, eax);
3218 } 3223 }
3219 3224
3220 3225
3221 } } // namespace v8::internal 3226 } } // namespace v8::internal
3222 3227
3223 #endif // V8_TARGET_ARCH_X87 3228 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x87/macro-assembler-x87.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698