Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 877233002: When an extension is unloaded, unregister all event listeners, not just the lazy ones. (Closed)

Created:
5 years, 11 months ago by Marijn Kruisselbrink
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When an extension is unloaded, unregister all event listeners, not just the lazy ones. This fixes a problem where event listeners could stick around for a short time period after an extension is unloaded, causing problems with the onInstalled event for a new version of an extension. BUG=449654 Committed: https://crrev.com/1a3586c0467a2e2f3777c060616e787bc9535c19 Cr-Commit-Position: refs/heads/master@{#313556}

Patch Set 1 #

Patch Set 2 : fix unittest compile #

Patch Set 3 : inform delegate when listeners are removed. should fix failing browser tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M extensions/browser/event_listener_map.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/event_listener_map.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M extensions/browser/event_listener_map_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/event_router.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Marijn Kruisselbrink
It probably makes sense to add the extension from the bug as testcase somewhere, although ...
5 years, 11 months ago (2015-01-28 00:35:04 UTC) #3
not at google - send to devlin
lgtm
5 years, 11 months ago (2015-01-28 00:35:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877233002/50001
5 years, 10 months ago (2015-01-28 18:32:58 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:50001)
5 years, 10 months ago (2015-01-28 19:07:15 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 19:08:23 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1a3586c0467a2e2f3777c060616e787bc9535c19
Cr-Commit-Position: refs/heads/master@{#313556}

Powered by Google App Engine
This is Rietveld 408576698