Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 877213003: Remove "ForcedLayer" from Sky (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
esprehn
CC:
mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M sky/engine/core/rendering/RenderLayerModelObject.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
5 years, 10 months ago (2015-01-27 23:21:48 UTC) #1
abarth-chromium
Committed patchset #1 (id:1) manually as 26e4278bd177d7a5313024306a777e664fff5b11 (presubmit successful).
5 years, 10 months ago (2015-01-27 23:22:19 UTC) #2
esprehn
lgtm, I wonder if we can get rid of OverflowClipLayer too. That'll probably change the ...
5 years, 10 months ago (2015-01-27 23:23:00 UTC) #3
abarth-chromium
Does the system know how to clip without OverflowClipLayer?
5 years, 10 months ago (2015-01-27 23:25:06 UTC) #4
esprehn
On 2015/01/27 at 23:25:06, abarth wrote: > Does the system know how to clip without ...
5 years, 10 months ago (2015-01-27 23:27:13 UTC) #5
abarth-chromium
5 years, 10 months ago (2015-01-27 23:29:27 UTC) #6
Message was sent while issue was closed.
On 2015/01/27 at 23:27:13, esprehn wrote:
> On 2015/01/27 at 23:25:06, abarth wrote:
> > Does the system know how to clip without OverflowClipLayer?
> 
> Yup, otherwise position: absolute + overflow: clip wouldn't work since that
gets you a NormalLayer. OverflowClipLayer is a "hack" to give you a layer, but
not mess with your paint order in the paint phases like NormalLayer did.

Oh, you're saying use NormalLayer for clipping.  Yeah, that might work.

Powered by Google App Engine
This is Rietveld 408576698