Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 877213002: cc: Attempt to deflake the LayerTreeHostPictureTestTwinLayer test. (Closed)

Created:
5 years, 11 months ago by danakj
Modified:
5 years, 11 months ago
Reviewers:
ajuma, vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, earthdok
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Attempt to deflake the LayerTreeHostPictureTestTwinLayer test. This test has been flaky (see bug), but I am not able to recreate the flake locally. However, this test does PostSetNeedsCommit() from the impl thread while also causing commits from the main thread in DidCommit which could cause an extra commit to happen in theory. This changes the test to stop using PostSetNeedsCommit() and always cause commits from DidCommit on the main thread, to help make the test more deterministic. R=ajuma, enne@chromium.org, vmpstr BUG=451988 Committed: https://crrev.com/c949ffe0242ad0459c43a5c9f80f6b29ddb5cbec Cr-Commit-Position: refs/heads/master@{#313400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M cc/trees/layer_tree_host_unittest_picture.cc View 3 chunks +19 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
danakj
5 years, 11 months ago (2015-01-27 22:56:37 UTC) #1
ajuma
lgtm, the test is much easier to understand now.
5 years, 11 months ago (2015-01-27 23:11:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877213002/1
5 years, 11 months ago (2015-01-27 23:22:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 23:36:52 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 23:40:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c949ffe0242ad0459c43a5c9f80f6b29ddb5cbec
Cr-Commit-Position: refs/heads/master@{#313400}

Powered by Google App Engine
This is Rietveld 408576698