chrome/browser/history/history_tab_helper.cc - Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_tab_helper.cc

Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/history_tab_helper.cc

diff --git a/chrome/browser/history/history_tab_helper.cc b/chrome/browser/history/history_tab_helper.cc

index ee04f6cf17e7b06ed923d83ff09734d2a98d0c05..8564749f464569747d06e9604ab3cd39f8cd4803 100644

--- a/chrome/browser/history/history_tab_helper.cc

+++ b/chrome/browser/history/history_tab_helper.cc

@@ -50,7 +50,7 @@ HistoryTabHelper::CreateHistoryAddPageArgs(

scoped_refptr<history::HistoryAddPageArgs> add_page_args(

new history::HistoryAddPageArgs(

params.url, base::Time::Now(), tab_contents(), params.page_id,

- params.referrer, params.redirects, params.transition,

+ params.referrer.url, params.redirects, params.transition,

history::SOURCE_BROWSED, details.did_replace_entry));

if (content::PageTransitionIsMainFrame(params.transition) &&

virtual_url != params.url) {