Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 877193003: ICU update to 54.1 step 7 (Closed)

Created:
5 years, 10 months ago by jungshik at Google
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

ICU update to 54.1 step 7 1. Fix a Windows build failure due to: a. 'signed vs unsigned' comparison b. 'possible data loss' in conversion : Apply pkasting's patch at http://bugs.icu-project.org/trac/ticket/11104 2. Drop a few currencies to cut down the data size by 50kB for non-Android platforms. 2. Build the ICU data for Android and check in. - Drop all display names for languages/scripts/regions except for zh-Han{s,t} as before. ( ~ 1.2MB reduction) - Drop cjdict by applying android/brkitr.patch. (~ 2MB reduction) - Include the display names for only 60+ currencies ( ~ 400kB reduction from the non-Android data. - Minimize the locale data for 9 locales Chrome on Android is not localized to. Drop currency names for those 9 locales. ( ~ 150kB reduction) Size change: 1. Non-android: 10,255,584 to 10,200,880 2. Android: - Final : 6,270,880 With 60+ currency names added (for bug 370849) and 9 unnecessary locale data dropped. It's 232,240 bytes larger than ICU 52.1 (6,038,640). - Without any currency names but with 9 unnecessary locale data: 6,026,816 - With 60+ currency names and 9 unnecessary locale data: 6,426,368 BUG=370849, 428145 TEST=Build on Windows. Blink layout tests, webkit unittests. R=mark@chromium.org, wangxianzhu@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/26c111a7abf1bf708c881928bb6b31f0746f6e14

Patch Set 1 #

Patch Set 2 : android data check in #

Patch Set 3 : readme update #

Patch Set 4 : fix a comment in patch_locale.sh #

Patch Set 5 : update CLDR_VERSION field to "%version%" in *local.mk files #

Patch Set 6 : add one more msvc's warning fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -7559 lines) Patch
M README.chromium View 1 2 3 4 5 2 chunks +11 lines, -3 lines 0 comments Download
A + android/currencies.list View 1 2 3 4 5 3 chunks +1 line, -56 lines 0 comments Download
M android/icudtl.dat View Binary file 0 comments Download
M android/patch_locale.sh View 1 2 3 4 5 1 chunk +74 lines, -9 lines 0 comments Download
M patches/vscomp.patch View 1 2 3 4 5 1 chunk +65 lines, -0 lines 0 comments Download
M scripts/currencies.list View 1 2 3 4 5 5 chunks +1 line, -12 lines 0 comments Download
M source/data/curr/af.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/agq.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/ak.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/am.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/ar.txt View 1 2 3 4 5 15 chunks +0 lines, -102 lines 0 comments Download
M source/data/curr/asa.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/az.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/bas.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/bez.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/bg.txt View 1 2 3 4 5 15 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/bm.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/bn.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/br.txt View 1 2 3 4 5 16 chunks +0 lines, -101 lines 0 comments Download
M source/data/curr/brx.txt View 1 2 3 4 5 7 chunks +0 lines, -36 lines 0 comments Download
M source/data/curr/bs.txt View 1 2 3 4 5 16 chunks +0 lines, -83 lines 0 comments Download
M source/data/curr/bs_Cyrl.txt View 1 2 3 4 5 14 chunks +0 lines, -81 lines 0 comments Download
M source/data/curr/ca.txt View 1 2 3 4 5 14 chunks +0 lines, -72 lines 0 comments Download
M source/data/curr/cgg.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/cs.txt View 1 2 3 4 5 15 chunks +0 lines, -92 lines 0 comments Download
M source/data/curr/cy.txt View 1 2 3 4 5 13 chunks +0 lines, -108 lines 0 comments Download
M source/data/curr/da.txt View 1 2 3 4 5 15 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/dav.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/de.txt View 1 2 3 4 5 16 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/dje.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/dsb.txt View 1 2 3 4 5 12 chunks +0 lines, -90 lines 0 comments Download
M source/data/curr/dz.txt View 1 2 3 4 5 2 chunks +0 lines, -8 lines 0 comments Download
M source/data/curr/ebu.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/ee.txt View 1 2 3 4 5 14 chunks +0 lines, -72 lines 0 comments Download
M source/data/curr/el.txt View 1 2 3 4 5 16 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/en.txt View 1 2 3 4 5 14 chunks +0 lines, -72 lines 0 comments Download
M source/data/curr/en_AG.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/en_AI.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/en_DM.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/en_FK.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/en_GB.txt View 1 2 3 4 5 10 chunks +0 lines, -42 lines 0 comments Download
M source/data/curr/en_GD.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/en_KN.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/en_KY.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/en_LC.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/en_MS.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/en_SB.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/en_SZ.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/en_VC.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/es.txt View 1 2 3 4 5 15 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/es_MX.txt View 1 2 3 4 5 5 chunks +0 lines, -36 lines 0 comments Download
M source/data/curr/et.txt View 1 2 3 4 5 15 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/eu.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/ewo.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/fa.txt View 1 2 3 4 5 7 chunks +0 lines, -40 lines 0 comments Download
M source/data/curr/ff.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/fi.txt View 1 2 3 4 5 16 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/fil.txt View 1 2 3 4 5 13 chunks +0 lines, -73 lines 0 comments Download
M source/data/curr/fr.txt View 1 2 3 4 5 16 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/fr_CA.txt View 1 2 3 4 5 3 chunks +0 lines, -16 lines 0 comments Download
M source/data/curr/fr_SY.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/fy.txt View 1 2 3 4 5 14 chunks +0 lines, -72 lines 0 comments Download
M source/data/curr/ga.txt View 1 2 3 4 5 16 chunks +0 lines, -101 lines 0 comments Download
M source/data/curr/gd.txt View 1 2 3 4 5 16 chunks +0 lines, -92 lines 0 comments Download
M source/data/curr/gl.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/gsw.txt View 1 2 3 4 5 14 chunks +0 lines, -72 lines 0 comments Download
M source/data/curr/gu.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/guz.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/ha.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/he.txt View 1 2 3 4 5 15 chunks +0 lines, -92 lines 0 comments Download
M source/data/curr/hi.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/hr.txt View 1 2 3 4 5 16 chunks +0 lines, -83 lines 0 comments Download
M source/data/curr/hsb.txt View 1 2 3 4 5 12 chunks +0 lines, -90 lines 0 comments Download
M source/data/curr/hu.txt View 1 2 3 4 5 15 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/hy.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/id.txt View 1 2 3 4 5 14 chunks +0 lines, -65 lines 0 comments Download
M source/data/curr/is.txt View 1 2 3 4 5 15 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/it.txt View 1 2 3 4 5 14 chunks +0 lines, -73 lines 0 comments Download
M source/data/curr/ja.txt View 1 2 3 4 5 14 chunks +0 lines, -65 lines 0 comments Download
M source/data/curr/jmc.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/ka.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/kab.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/kam.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/kde.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/kea.txt View 1 2 3 4 5 6 chunks +0 lines, -35 lines 0 comments Download
M source/data/curr/khq.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/ki.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/kk.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/kln.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/km.txt View 1 2 3 4 5 13 chunks +0 lines, -65 lines 0 comments Download
M source/data/curr/kn.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/ko.txt View 1 2 3 4 5 14 chunks +0 lines, -65 lines 0 comments Download
M source/data/curr/ks.txt View 1 2 3 4 5 7 chunks +0 lines, -32 lines 0 comments Download
M source/data/curr/ksb.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/ksf.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/ksh.txt View 1 2 3 4 5 8 chunks +0 lines, -46 lines 0 comments Download
M source/data/curr/ky.txt View 1 2 3 4 5 13 chunks +0 lines, -73 lines 0 comments Download
M source/data/curr/lag.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/lb.txt View 1 2 3 4 5 14 chunks +0 lines, -72 lines 0 comments Download
M source/data/curr/lg.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/ln.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/lo.txt View 1 2 3 4 5 14 chunks +0 lines, -65 lines 0 comments Download
M source/data/curr/lt.txt View 1 2 3 4 5 16 chunks +0 lines, -92 lines 0 comments Download
M source/data/curr/lu.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/luo.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/luy.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/lv.txt View 1 2 3 4 5 15 chunks +0 lines, -83 lines 0 comments Download
M source/data/curr/mas.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/mer.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/mfe.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/mg.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/mk.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/ml.txt View 1 2 3 4 5 16 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/mn.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/mr.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/ms.txt View 1 2 3 4 5 13 chunks +0 lines, -65 lines 0 comments Download
M source/data/curr/mua.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/my.txt View 1 2 3 4 5 12 chunks +0 lines, -63 lines 0 comments Download
M source/data/curr/naq.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/nb.txt View 1 2 3 4 5 16 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/nd.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/ne.txt View 1 2 3 4 5 12 chunks +0 lines, -72 lines 0 comments Download
M source/data/curr/nl.txt View 1 2 3 4 5 16 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/nmg.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/nn.txt View 1 2 3 4 5 13 chunks +0 lines, -68 lines 0 comments Download
M source/data/curr/nyn.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/pa.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/pl.txt View 1 2 3 4 5 15 chunks +0 lines, -92 lines 0 comments Download
M source/data/curr/pt.txt View 1 2 3 4 5 16 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/pt_PT.txt View 1 2 3 4 5 8 chunks +0 lines, -32 lines 0 comments Download
M source/data/curr/pt_ST.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/reslocal.mk View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M source/data/curr/rm.txt View 1 2 3 4 5 9 chunks +0 lines, -44 lines 0 comments Download
M source/data/curr/rn.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/ro.txt View 1 2 3 4 5 15 chunks +0 lines, -83 lines 0 comments Download
M source/data/curr/rof.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/root.txt View 1 2 3 4 5 5 chunks +0 lines, -15 lines 0 comments Download
M source/data/curr/ru.txt View 1 2 3 4 5 15 chunks +0 lines, -92 lines 0 comments Download
M source/data/curr/rwk.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/saq.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/sbp.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/seh.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/ses.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/sg.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/shi.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/shi_Latn.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/si.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/sk.txt View 1 2 3 4 5 15 chunks +0 lines, -92 lines 0 comments Download
M source/data/curr/sl.txt View 1 2 3 4 5 15 chunks +0 lines, -92 lines 0 comments Download
M source/data/curr/sn.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/sq.txt View 1 2 3 4 5 12 chunks +0 lines, -72 lines 0 comments Download
M source/data/curr/sr.txt View 1 2 3 4 5 16 chunks +0 lines, -83 lines 0 comments Download
M source/data/curr/sr_Latn.txt View 1 2 3 4 5 16 chunks +0 lines, -83 lines 0 comments Download
M source/data/curr/sv.txt View 1 2 3 4 5 16 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/sw.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/swc.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/ta.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/te.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/teo.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/th.txt View 1 2 3 4 5 14 chunks +0 lines, -65 lines 0 comments Download
M source/data/curr/to.txt View 1 2 3 4 5 1 chunk +0 lines, -9 lines 0 comments Download
M source/data/curr/tr.txt View 1 2 3 4 5 15 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/twq.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/tzm.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/ug.txt View 1 2 3 4 5 14 chunks +0 lines, -72 lines 0 comments Download
M source/data/curr/uk.txt View 1 2 3 4 5 15 chunks +0 lines, -92 lines 0 comments Download
M source/data/curr/ur.txt View 1 2 3 4 5 14 chunks +0 lines, -74 lines 0 comments Download
M source/data/curr/uz.txt View 1 2 3 4 5 13 chunks +0 lines, -73 lines 0 comments Download
M source/data/curr/uz_Cyrl.txt View 1 2 3 4 5 6 chunks +0 lines, -28 lines 0 comments Download
M source/data/curr/vai.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/vai_Latn.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/vi.txt View 1 2 3 4 5 14 chunks +0 lines, -65 lines 0 comments Download
M source/data/curr/vun.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/xog.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/yo.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/yo_BJ.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M source/data/curr/zgh.txt View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M source/data/curr/zh.txt View 1 2 3 4 5 14 chunks +0 lines, -65 lines 0 comments Download
M source/data/curr/zh_Hans_HK.txt View 1 2 3 4 5 2 chunks +0 lines, -7 lines 0 comments Download
M source/data/curr/zh_Hant.txt View 1 2 3 4 5 14 chunks +0 lines, -65 lines 0 comments Download
M source/data/curr/zh_Hant_HK.txt View 1 2 3 4 5 3 chunks +0 lines, -10 lines 0 comments Download
M source/data/curr/zu.txt View 1 2 3 4 5 9 chunks +0 lines, -45 lines 0 comments Download
M source/data/in/icudtl.dat View Binary file 0 comments Download
M source/data/lang/reslocal.mk View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M source/data/locales/reslocal.mk View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M source/data/rbnf/rbnflocal.mk View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M source/data/region/reslocal.mk View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M source/data/zone/reslocal.mk View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M source/i18n/collationfastlatin.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M source/i18n/decimfmt.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M source/i18n/digitlst.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M source/i18n/regexcmp.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jungshik at Google
Can you take a look? The ICU data for Android would have been smaller than ...
5 years, 10 months ago (2015-01-28 21:55:22 UTC) #2
Xianzhu
lgtm. +andrewhayden@ who is actively working on ICU for chrome android.
5 years, 10 months ago (2015-01-28 22:15:53 UTC) #4
Mark Mentovai
LGTM (stamp + spot-check)
5 years, 10 months ago (2015-01-28 22:39:23 UTC) #5
jungshik at Google
5 years, 10 months ago (2015-01-31 00:49:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #6 (id:50001) manually as
26c111a7abf1bf708c881928bb6b31f0746f6e14 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698