[Android] Fix new tab not to show 'about:blank' at the beginning

This is the necessary change in the upstream to fix the issue.

Pipe DidStartNavigationToPendingEntry to WebContentsObserver and TabObserver.

BUG=442726
Committed: https://crrev.com/4bd261aa366bb94978366d0081b289b92648b810
Cr-Commit-Position: refs/heads/master@{#313866}

[Changwan Ryu, 2015-01-28 07:35:47]

changwan@chromium.org changed reviewers:
+ dtrainor@chromium.org, mariakhomenko@chromium.org, tedchoc@chromium.org

[Changwan Ryu, 2015-01-28 09:03:47]

The differences b/w patch 1 an patch 2:

The first approach (in line with
https://chrome-internal-review.googlesource.com/#/c/193757/3) is to format the
original target URL as well. But it adds some unnecessary calls to
toolbar_model_delegate and toolbar_model_android.

With the second approach (in line with
https://chrome-internal-review.googlesource.com/#/c/193757/4) shows the URL as
is, so 'http://' will still be attached as it gets shown to the user.

[Maria, 2015-01-28 18:34:49]

https://codereview.chromium.org/877163005/diff/20001/chrome/android/java/src/...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://codereview.chromium.org/877163005/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:260: private String
mOriginalTargetUrl;
should this be final?

https://codereview.chromium.org/877163005/diff/20001/chrome/browser/ui/toolba...
File chrome/browser/ui/toolbar/toolbar_model_impl.cc (right):

https://codereview.chromium.org/877163005/diff/20001/chrome/browser/ui/toolba...
chrome/browser/ui/toolbar/toolbar_model_impl.cc:247: return GURL();
It seems like if no original url was set, we will now get a different behaviour
in this case (empty string vs about:blank)

[David Trainor- moved to gerrit, 2015-01-28 19:42:43]

https://chromiumcodereview.appspot.com/877163005/diff/20001/chrome/android/ja...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://chromiumcodereview.appspot.com/877163005/diff/20001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:674: if (targetUrl
!= null) mOriginalTargetUrl = targetUrl;
Is there no way to populate this in initialize() from the WebContents?  Just
making sure.

https://chromiumcodereview.appspot.com/877163005/diff/20001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1513: if
(mOriginalTargetUrl != null) return mOriginalTargetUrl;
Should we always be returning this?  Should we clear it out once we get the
first valid load call?

https://chromiumcodereview.appspot.com/877163005/diff/20001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:2298: public String
getOriginalTargetUrl() {
Javadoc

[David Trainor- moved to gerrit, 2015-01-29 21:24:22]

lgtm pending nits/removing reloadType.

https://chromiumcodereview.appspot.com/877163005/diff/60001/chrome/android/ja...
File chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java
(right):

https://chromiumcodereview.appspot.com/877163005/diff/60001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java:263: public
void onDidStartNavigationToPendingEntry(Tab tab, String url, int reloadType);
Javadoc.  Remove reloadType IMO

https://chromiumcodereview.appspot.com/877163005/diff/60001/content/browser/a...
File content/browser/android/web_contents_observer_android.h (right):

https://chromiumcodereview.appspot.com/877163005/diff/60001/content/browser/a...
content/browser/android/web_contents_observer_android.h:75: virtual void
DidStartNavigationToPendingEntry(
Remove virtual (not supposed to have it with override).  Might as well remove
all virtuals on methods that have override in this file actually :).

https://chromiumcodereview.appspot.com/877163005/diff/60001/content/public/an...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java
(right):

https://chromiumcodereview.appspot.com/877163005/diff/60001/content/public/an...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java:201:
* @param reloadType An enum value defined in navigation_controller.h
Don't pass reloadType.  I don't think we need it.  If we're going to pass it we
need to do the auto-generated enum -> Java constant stuff.

[Ted C, 2015-01-29 21:42:08]

https://chromiumcodereview.appspot.com/877163005/diff/60001/chrome/android/ja...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://chromiumcodereview.appspot.com/877163005/diff/60001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:2284: public
boolean isCurrentNavigationEntryInitial() {
I wouldn't add this here.  It's just is a helper function and Tab exposes all
the bits it needs to for the callers to do this on their own (and there are not
enough callers to necessitate this helper IMHO).

[Ted C, 2015-01-29 21:42:42]

On 2015/01/29 21:42:08, Ted C wrote:
>
https://chromiumcodereview.appspot.com/877163005/diff/60001/chrome/android/ja...
> File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):
> 
>
https://chromiumcodereview.appspot.com/877163005/diff/60001/chrome/android/ja...
> chrome/android/java/src/org/chromium/chrome/browser/Tab.java:2284: public
> boolean isCurrentNavigationEntryInitial() {
> I wouldn't add this here.  It's just is a helper function and Tab exposes all
> the bits it needs to for the callers to do this on their own (and there are
not
> enough callers to necessitate this helper IMHO).

lgtm as well..pending the comments

[Changwan Ryu, 2015-01-30 00:03:24]

https://chromiumcodereview.appspot.com/877163005/diff/60001/chrome/android/ja...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://chromiumcodereview.appspot.com/877163005/diff/60001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:2284: public
boolean isCurrentNavigationEntryInitial() {
On 2015/01/29 21:42:08, Ted C wrote:
> I wouldn't add this here.  It's just is a helper function and Tab exposes all
> the bits it needs to for the callers to do this on their own (and there are
not
> enough callers to necessitate this helper IMHO).

Done.

https://chromiumcodereview.appspot.com/877163005/diff/60001/chrome/android/ja...
File chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java
(right):

https://chromiumcodereview.appspot.com/877163005/diff/60001/chrome/android/ja...
chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java:263: public
void onDidStartNavigationToPendingEntry(Tab tab, String url, int reloadType);
On 2015/01/29 21:24:21, David Trainor wrote:
> Javadoc.  Remove reloadType IMO

Done.

https://chromiumcodereview.appspot.com/877163005/diff/60001/content/browser/a...
File content/browser/android/web_contents_observer_android.h (right):

https://chromiumcodereview.appspot.com/877163005/diff/60001/content/browser/a...
content/browser/android/web_contents_observer_android.h:75: virtual void
DidStartNavigationToPendingEntry(
On 2015/01/29 21:24:21, David Trainor wrote:
> Remove virtual (not supposed to have it with override).  Might as well remove
> all virtuals on methods that have override in this file actually :).

Done.

https://chromiumcodereview.appspot.com/877163005/diff/60001/content/public/an...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java
(right):

https://chromiumcodereview.appspot.com/877163005/diff/60001/content/public/an...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java:201:
* @param reloadType An enum value defined in navigation_controller.h
On 2015/01/29 21:24:21, David Trainor wrote:
> Don't pass reloadType.  I don't think we need it.  If we're going to pass it
we
> need to do the auto-generated enum -> Java constant stuff.

Done.

[Changwan Ryu, 2015-01-30 00:06:30]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2015-01-30 00:06:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/877163005/100001

[commit-bot: I haz the power, 2015-01-30 01:50:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-30 01:50:37]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Changwan Ryu, 2015-01-30 02:08:44]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2015-01-30 02:09:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/877163005/100001

[commit-bot: I haz the power, 2015-01-30 03:48:35]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-01-30 03:49:16]

Patchset 6 (id:??) landed as
https://crrev.com/4bd261aa366bb94978366d0081b289b92648b810
Cr-Commit-Position: refs/heads/master@{#313866}