Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 877113002: use murmur3 finisher to improve font hash efficiency (Closed)

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 10 months ago
Reviewers:
herb_g, herb, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use murmur3 finisher to improve font hash efficiency. Add dump() method to inspect glyphcache strikes. Murmur addition improves hash efficient roughly 50% BUG=skia: Committed: https://skia.googlesource.com/skia/+/40dab98de1bdb803035304077f43410d1f86f2d2

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : init to 0, and check for div-by-zero #

Total comments: 2

Patch Set 4 : add CheapMix helper" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -30 lines) Patch
M samplecode/SamplePictFile.cpp View 1 2 chunks +11 lines, -0 lines 0 comments Download
M src/core/SkChecksum.h View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M src/core/SkGlyphCache.h View 1 2 3 6 chunks +17 lines, -6 lines 0 comments Download
M src/core/SkGlyphCache.cpp View 1 2 3 8 chunks +60 lines, -24 lines 0 comments Download
M src/core/SkScalerContext.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (6 generated)
reed1
ptal
5 years, 11 months ago (2015-01-27 16:57:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877113002/20001
5 years, 11 months ago (2015-01-27 16:58:29 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-27 16:58:29 UTC) #5
mtklein
https://codereview.chromium.org/877113002/diff/20001/src/core/SkGlyphCache.cpp File src/core/SkGlyphCache.cpp (right): https://codereview.chromium.org/877113002/diff/20001/src/core/SkGlyphCache.cpp#newcode82 src/core/SkGlyphCache.cpp:82: fHashHitCount = fHashMissCount = 1; 0? https://codereview.chromium.org/877113002/diff/20001/src/core/SkGlyphCache.h File src/core/SkGlyphCache.h ...
5 years, 11 months ago (2015-01-27 17:10:12 UTC) #7
reed1
https://codereview.chromium.org/877113002/diff/20001/src/core/SkGlyphCache.cpp File src/core/SkGlyphCache.cpp (right): https://codereview.chromium.org/877113002/diff/20001/src/core/SkGlyphCache.cpp#newcode82 src/core/SkGlyphCache.cpp:82: fHashHitCount = fHashMissCount = 1; On 2015/01/27 17:10:12, mtklein ...
5 years, 11 months ago (2015-01-27 18:33:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877113002/40001
5 years, 11 months ago (2015-01-27 18:33:49 UTC) #10
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-27 18:33:50 UTC) #11
mtklein
https://codereview.chromium.org/877113002/diff/40001/src/core/SkGlyphCache.h File src/core/SkGlyphCache.h (right): https://codereview.chromium.org/877113002/diff/40001/src/core/SkGlyphCache.h#newcode215 src/core/SkGlyphCache.h:215: static inline unsigned ID2HashIndex(uint32_t h) { SkChecksum::MixLess?
5 years, 11 months ago (2015-01-27 22:28:22 UTC) #12
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-27 22:32:17 UTC) #13
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-28 00:06:06 UTC) #14
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-28 00:49:29 UTC) #15
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 10 months ago (2015-01-28 06:49:29 UTC) #17
reed1
ptal https://codereview.chromium.org/877113002/diff/40001/src/core/SkGlyphCache.h File src/core/SkGlyphCache.h (right): https://codereview.chromium.org/877113002/diff/40001/src/core/SkGlyphCache.h#newcode215 src/core/SkGlyphCache.h:215: static inline unsigned ID2HashIndex(uint32_t h) { On 2015/01/27 ...
5 years, 10 months ago (2015-01-28 21:22:40 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877113002/60001
5 years, 10 months ago (2015-01-28 21:23:28 UTC) #20
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-01-28 21:23:30 UTC) #21
mtklein
lgtm
5 years, 10 months ago (2015-01-28 21:24:53 UTC) #22
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 21:28:57 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/40dab98de1bdb803035304077f43410d1f86f2d2

Powered by Google App Engine
This is Rietveld 408576698