Issue 877093003: Add a missing BUILD dep for app_child_process.mojom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 877093003: Add a missing BUILD dep for app_child_process.mojom. (Closed)

Created:
5 years, 10 months ago by ppi

Modified:
5 years, 10 months ago

Reviewers:
jamesr, qsr

CC:
mojo-reviews_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Add a missing BUILD dep for app_child_process.mojom. https://codereview.chromium.org/868463008 imports application.mojom in app_child_process.mojom - this patch adds a corresponding BUILD dep. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a121d2c16f5a720b55443f3370ad7650d6164ec6

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	shell/BUILD.gn	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

ppi

this should fix the trybots (see https://build.chromium.org/p/tryserver.client.mojo/builders/Mojo%20Linux%20Try ) Thanks, Ben!

5 years, 10 months ago (2015-01-27 17:26:54 UTC) #5

ppi

5 years, 10 months ago (2015-01-27 17:27:10 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a121d2c16f5a720b55443f3370ad7650d6164ec6 (presubmit successful).