Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Side by Side Diff: content/renderer/scheduler/renderer_scheduler_impl.cc

Issue 877043004: Revert of scheduler: Increase work batch size to 4 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/scheduler/renderer_scheduler_impl.h" 5 #include "content/renderer/scheduler/renderer_scheduler_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/message_loop/message_loop_proxy.h" 8 #include "base/message_loop/message_loop_proxy.h"
9 #include "base/trace_event/trace_event.h" 9 #include "base/trace_event/trace_event.h"
10 #include "base/trace_event/trace_event_argument.h" 10 #include "base/trace_event/trace_event_argument.h"
(...skipping 27 matching lines...) Expand all
38 end_idle_period_closure_.Reset(base::Bind( 38 end_idle_period_closure_.Reset(base::Bind(
39 &RendererSchedulerImpl::EndIdlePeriod, weak_renderer_scheduler_ptr_)); 39 &RendererSchedulerImpl::EndIdlePeriod, weak_renderer_scheduler_ptr_));
40 idle_task_runner_ = make_scoped_refptr(new SingleThreadIdleTaskRunner( 40 idle_task_runner_ = make_scoped_refptr(new SingleThreadIdleTaskRunner(
41 task_queue_manager_->TaskRunnerForQueue(IDLE_TASK_QUEUE), 41 task_queue_manager_->TaskRunnerForQueue(IDLE_TASK_QUEUE),
42 base::Bind(&RendererSchedulerImpl::CurrentIdleTaskDeadlineCallback, 42 base::Bind(&RendererSchedulerImpl::CurrentIdleTaskDeadlineCallback,
43 weak_renderer_scheduler_ptr_))); 43 weak_renderer_scheduler_ptr_)));
44 renderer_task_queue_selector_->SetQueuePriority( 44 renderer_task_queue_selector_->SetQueuePriority(
45 CONTROL_TASK_QUEUE, RendererTaskQueueSelector::CONTROL_PRIORITY); 45 CONTROL_TASK_QUEUE, RendererTaskQueueSelector::CONTROL_PRIORITY);
46 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE); 46 renderer_task_queue_selector_->DisableQueue(IDLE_TASK_QUEUE);
47 task_queue_manager_->SetAutoPump(IDLE_TASK_QUEUE, false); 47 task_queue_manager_->SetAutoPump(IDLE_TASK_QUEUE, false);
48 // See crbug.com/444764 for how this work batch size was derived. 48 // TODO(skyostil): Increase this to 4 (crbug.com/444764).
49 task_queue_manager_->SetWorkBatchSize(4); 49 task_queue_manager_->SetWorkBatchSize(1);
50 50
51 for (size_t i = 0; i < TASK_QUEUE_COUNT; i++) { 51 for (size_t i = 0; i < TASK_QUEUE_COUNT; i++) {
52 task_queue_manager_->SetQueueName( 52 task_queue_manager_->SetQueueName(
53 i, TaskQueueIdToString(static_cast<QueueId>(i))); 53 i, TaskQueueIdToString(static_cast<QueueId>(i)));
54 } 54 }
55 TRACE_EVENT_OBJECT_CREATED_WITH_ID( 55 TRACE_EVENT_OBJECT_CREATED_WITH_ID(
56 TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"), "RendererScheduler", 56 TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"), "RendererScheduler",
57 this); 57 this);
58 } 58 }
59 59
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 state->SetDouble("last_input_time", 333 state->SetDouble("last_input_time",
334 (last_input_time_ - base::TimeTicks()).InMillisecondsF()); 334 (last_input_time_ - base::TimeTicks()).InMillisecondsF());
335 state->SetDouble( 335 state->SetDouble(
336 "estimated_next_frame_begin", 336 "estimated_next_frame_begin",
337 (estimated_next_frame_begin_ - base::TimeTicks()).InMillisecondsF()); 337 (estimated_next_frame_begin_ - base::TimeTicks()).InMillisecondsF());
338 338
339 return state; 339 return state;
340 } 340 }
341 341
342 } // namespace content 342 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698