Index: net/cookies/parsed_cookie_unittest.cc |
diff --git a/net/cookies/parsed_cookie_unittest.cc b/net/cookies/parsed_cookie_unittest.cc |
index 9f231e83efbadca60aa869655f1024194f35c22b..61a616777991d599d5a64abd2cbbfa28cfc69f77 100644 |
--- a/net/cookies/parsed_cookie_unittest.cc |
+++ b/net/cookies/parsed_cookie_unittest.cc |
@@ -92,16 +92,18 @@ TEST(ParsedCookieTest, TestNameless) { |
} |
TEST(ParsedCookieTest, TestAttributeCase) { |
- ParsedCookie pc("BLAHHH; Path=/; sECuRe; httpONLY; pRIoRitY=hIgH"); |
+ ParsedCookie pc( |
+ "BLAHHH; Path=/; sECuRe; httpONLY; first-PaRty-only; pRIoRitY=hIgH"); |
EXPECT_TRUE(pc.IsValid()); |
EXPECT_TRUE(pc.IsSecure()); |
EXPECT_TRUE(pc.IsHttpOnly()); |
+ EXPECT_TRUE(pc.IsFirstPartyOnly()); |
EXPECT_TRUE(pc.HasPath()); |
EXPECT_EQ("/", pc.Path()); |
EXPECT_EQ("", pc.Name()); |
EXPECT_EQ("BLAHHH", pc.Value()); |
EXPECT_EQ(COOKIE_PRIORITY_HIGH, pc.Priority()); |
- EXPECT_EQ(4U, pc.NumberOfAttributes()); |
+ EXPECT_EQ(5U, pc.NumberOfAttributes()); |
} |
TEST(ParsedCookieTest, TestDoubleQuotedNameless) { |
@@ -146,14 +148,15 @@ TEST(ParsedCookieTest, MissingValue) { |
} |
TEST(ParsedCookieTest, Whitespace) { |
- ParsedCookie pc(" A = BC ;secure;;; httponly"); |
+ ParsedCookie pc(" A = BC ;secure;;; first-party-only "); |
EXPECT_TRUE(pc.IsValid()); |
EXPECT_EQ("A", pc.Name()); |
EXPECT_EQ("BC", pc.Value()); |
EXPECT_FALSE(pc.HasPath()); |
EXPECT_FALSE(pc.HasDomain()); |
EXPECT_TRUE(pc.IsSecure()); |
- EXPECT_TRUE(pc.IsHttpOnly()); |
+ EXPECT_FALSE(pc.IsHttpOnly()); |
+ EXPECT_TRUE(pc.IsFirstPartyOnly()); |
EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); |
// We parse anything between ; as attributes, so we end up with two |
// attributes with an empty string name and value. |
@@ -168,6 +171,7 @@ TEST(ParsedCookieTest, MultipleEquals) { |
EXPECT_FALSE(pc.HasDomain()); |
EXPECT_TRUE(pc.IsSecure()); |
EXPECT_TRUE(pc.IsHttpOnly()); |
+ EXPECT_FALSE(pc.IsFirstPartyOnly()); |
EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, pc.Priority()); |
EXPECT_EQ(4U, pc.NumberOfAttributes()); |
} |
@@ -353,11 +357,12 @@ TEST(ParsedCookieTest, SetAttributes) { |
EXPECT_TRUE(pc.SetIsSecure(true)); |
EXPECT_TRUE(pc.SetIsHttpOnly(true)); |
EXPECT_TRUE(pc.SetIsHttpOnly(true)); |
+ EXPECT_TRUE(pc.SetIsFirstPartyOnly(true)); |
EXPECT_TRUE(pc.SetPriority("HIGH")); |
EXPECT_EQ( |
"name=value; domain=domain.com; path=/; " |
"expires=Sun, 18-Apr-2027 21:06:29 GMT; max-age=12345; secure; " |
- "httponly; priority=HIGH", |
+ "httponly; first-party-only; priority=HIGH", |
pc.ToCookieLine()); |
EXPECT_TRUE(pc.HasDomain()); |
EXPECT_TRUE(pc.HasPath()); |
@@ -365,6 +370,7 @@ TEST(ParsedCookieTest, SetAttributes) { |
EXPECT_TRUE(pc.HasMaxAge()); |
EXPECT_TRUE(pc.IsSecure()); |
EXPECT_TRUE(pc.IsHttpOnly()); |
+ EXPECT_TRUE(pc.IsFirstPartyOnly()); |
EXPECT_EQ(COOKIE_PRIORITY_HIGH, pc.Priority()); |
// Clear one attribute from the middle. |
@@ -377,7 +383,7 @@ TEST(ParsedCookieTest, SetAttributes) { |
EXPECT_EQ( |
"name=value; domain=domain.com; path=/foo; " |
"expires=Sun, 18-Apr-2027 21:06:29 GMT; max-age=12345; secure; " |
- "httponly; priority=HIGH", |
+ "httponly; first-party-only; priority=HIGH", |
pc.ToCookieLine()); |
// Set priority to medium. |
@@ -385,7 +391,7 @@ TEST(ParsedCookieTest, SetAttributes) { |
EXPECT_EQ( |
"name=value; domain=domain.com; path=/foo; " |
"expires=Sun, 18-Apr-2027 21:06:29 GMT; max-age=12345; secure; " |
- "httponly; priority=medium", |
+ "httponly; first-party-only; priority=medium", |
pc.ToCookieLine()); |
// Clear the rest and change the name and value. |
@@ -395,6 +401,7 @@ TEST(ParsedCookieTest, SetAttributes) { |
EXPECT_TRUE(pc.SetMaxAge(std::string())); |
EXPECT_TRUE(pc.SetIsSecure(false)); |
EXPECT_TRUE(pc.SetIsHttpOnly(false)); |
+ EXPECT_TRUE(pc.SetIsFirstPartyOnly(false)); |
EXPECT_TRUE(pc.SetName("name2")); |
EXPECT_TRUE(pc.SetValue("value2")); |
EXPECT_TRUE(pc.SetPriority(std::string())); |
@@ -404,6 +411,7 @@ TEST(ParsedCookieTest, SetAttributes) { |
EXPECT_FALSE(pc.HasMaxAge()); |
EXPECT_FALSE(pc.IsSecure()); |
EXPECT_FALSE(pc.IsHttpOnly()); |
+ EXPECT_FALSE(pc.IsFirstPartyOnly()); |
EXPECT_EQ("name2=value2", pc.ToCookieLine()); |
} |