Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Unified Diff: chrome/browser/extensions/api/cookies/cookies_api.cc

Issue 876973003: Implement the "first-party-only" cookie flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/cookies/cookies_api.cc
diff --git a/chrome/browser/extensions/api/cookies/cookies_api.cc b/chrome/browser/extensions/api/cookies/cookies_api.cc
index d059071dbfa1f9247c7ec32d11c135aafd0ec6bf..1f5f8f28562e1576ffb7ffc4c118bb80077fb966 100644
--- a/chrome/browser/extensions/api/cookies/cookies_api.cc
+++ b/chrome/browser/extensions/api/cookies/cookies_api.cc
@@ -385,9 +385,8 @@ void CookiesSetFunction::SetCookieOnIOThread() {
}
cookie_monster->SetCookieWithDetailsAsync(
- url_,
- parsed_args_->details.name.get() ? *parsed_args_->details.name
- : std::string(),
+ url_, parsed_args_->details.name.get() ? *parsed_args_->details.name
+ : std::string(),
parsed_args_->details.value.get() ? *parsed_args_->details.value
: std::string(),
parsed_args_->details.domain.get() ? *parsed_args_->details.domain
@@ -399,6 +398,7 @@ void CookiesSetFunction::SetCookieOnIOThread() {
: false,
parsed_args_->details.http_only.get() ? *parsed_args_->details.http_only
: false,
+ false, // TODO(mkwst): FirstParty
Bernhard Bauer 2015/02/20 11:10:17 Can you elaborate on this TODO?
Mike West 2015/02/23 05:06:59 If we end up shipping this, we'll need to extend t
net::COOKIE_PRIORITY_DEFAULT,
base::Bind(&CookiesSetFunction::PullCookie, this));
}
« no previous file with comments | « chrome/browser/chromeos/login/profile_auth_data_unittest.cc ('k') | chrome/browser/extensions/api/cookies/cookies_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698